Skip to content

Conversation

lhy1024
Copy link
Contributor

@lhy1024 lhy1024 commented Nov 6, 2024

What problem does this PR solve?

Issue Number: close #57166

Problem Summary:

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@sre-bot
Copy link
Contributor

sre-bot commented Nov 6, 2024

CLA assistant check
All committers have signed the CLA.

@ti-chi-bot ti-chi-bot bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 6, 2024
Copy link

tiprow bot commented Nov 6, 2024

Hi @lhy1024. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@hawkingrei
Copy link
Member

@lhy1024 Please fix the conflict.

@lhy1024 lhy1024 changed the title util: add log when etcd watch meet cancel owner: add log when etcd watch meet cancel Nov 6, 2024
Copy link

codecov bot commented Nov 6, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 74.7153%. Comparing base (9fed88c) to head (817d7b4).
Report is 2 commits behind head on master.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #57154        +/-   ##
================================================
+ Coverage   73.1051%   74.7153%   +1.6102%     
================================================
  Files          1701       1747        +46     
  Lines        469763     477982      +8219     
================================================
+ Hits         343421     357126     +13705     
+ Misses       105168      98342      -6826     
- Partials      21174      22514      +1340     
Flag Coverage Δ
integration 48.7399% <0.0000%> (?)
unit 72.2822% <0.0000%> (-0.0419%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.6910% <ø> (ø)
parser ∅ <ø> (∅)
br 62.2282% <ø> (+15.1657%) ⬆️
🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Nov 6, 2024
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Nov 6, 2024
Copy link

ti-chi-bot bot commented Nov 6, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-11-06 07:19:57.998087167 +0000 UTC m=+1025510.837242711: ☑️ agreed by okJiang.
  • 2024-11-06 07:21:22.785683915 +0000 UTC m=+1025595.624839456: ☑️ agreed by nolouch.

@lhy1024
Copy link
Contributor Author

lhy1024 commented Nov 19, 2024

@wjhuang2016 PTAL

Copy link

ti-chi-bot bot commented Mar 7, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hawkingrei, JmPotato, nolouch, okJiang, wjhuang2016

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Mar 7, 2025
@ti-chi-bot ti-chi-bot bot merged commit bf21e59 into pingcap:master Mar 7, 2025
22 checks passed
zeminzhou pushed a commit to zeminzhou/tidb that referenced this pull request May 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add log when etcd watch meet cancel
7 participants