Skip to content

Conversation

you06
Copy link
Contributor

@you06 you06 commented Nov 7, 2024

What problem does this PR solve?

Issue Number: close #57191

Problem Summary:

What changed and how does it work?

Ignore the function github.com/tikv/client-go/v2/txnkv/transaction.(*twoPhaseCommitter).resolveFlushedLocks.func1 which runs in background. This function is responsible for commit/rollback locks and transaction status broadcast, which is running in background by designed, and it should not break goleak verification.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-triage-completed release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 7, 2024
Copy link

tiprow bot commented Nov 7, 2024

Hi @you06. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@you06 you06 requested review from cfzjywxk and ekexium November 7, 2024 07:14
@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Nov 7, 2024
Copy link

codecov bot commented Nov 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.1220%. Comparing base (74034d4) to head (718f62a).
Report is 237 commits behind head on master.

Additional details and impacted files
@@                Coverage Diff                @@
##             master     #57198         +/-   ##
=================================================
- Coverage   73.3650%   57.1220%   -16.2430%     
=================================================
  Files          1624       1774        +150     
  Lines        448069     665529     +217460     
=================================================
+ Hits         328726     380164      +51438     
- Misses        99206     260971     +161765     
- Partials      20137      24394       +4257     
Flag Coverage Δ
integration 36.4793% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.9478% <ø> (ø)
parser ∅ <ø> (∅)
br 49.8125% <ø> (+4.2995%) ⬆️

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Nov 7, 2024
Copy link

ti-chi-bot bot commented Nov 7, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-11-07 07:22:15.867469146 +0000 UTC m=+1112048.706624684: ☑️ agreed by ekexium.
  • 2024-11-07 08:04:04.891056114 +0000 UTC m=+1114557.730211659: ☑️ agreed by hawkingrei.

Copy link

tiprow bot commented Nov 7, 2024

@you06: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
tidb_parser_test 718f62a link true /test tidb_parser_test
fast_test_tiprow 718f62a link true /test fast_test_tiprow

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Copy link

ti-chi-bot bot commented Nov 7, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cfzjywxk, ekexium, hawkingrei

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [cfzjywxk,ekexium,hawkingrei]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot merged commit a5268a2 into pingcap:master Nov 7, 2024
21 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

routine leak in TestRejectUnsupportedTables
4 participants