Skip to content

domain: set right order to compaign stats owner #57200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 7, 2024
Merged

domain: set right order to compaign stats owner #57200

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ab27987
domain: set right order to compaign stats owner
hawkingrei Nov 7, 2024
22203e3
domain: set right order to compaign stats owner
hawkingrei Nov 7, 2024
542956b
update
hawkingrei Nov 7, 2024
4b60d4b
update
hawkingrei Nov 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 12 additions & 7 deletions pkg/domain/domain.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2063,6 +2063,11 @@ func (do *Domain) LoadBindInfoLoop(ctxForHandle sessionctx.Context, ctxForEvolve
}

owner := do.newOwnerManager(bindinfo.Prompt, bindinfo.OwnerKey)
err = owner.CampaignOwner()
if err != nil {
logutil.BgLogger().Warn("campaign owner failed", zap.Error(err))
return err
}
do.globalBindHandleWorkerLoop(owner)
return nil
}
Expand Down Expand Up @@ -2387,6 +2392,13 @@ func (do *Domain) UpdateTableStatsLoop(ctx, initStatsCtx sessionctx.Context) err
variable.DisableStatsOwner = do.disableStatsOwner
do.statsOwner = do.newOwnerManager(handle.StatsPrompt, handle.StatsOwnerKey)
do.statsOwner.SetListener(owner.NewListenersWrapper(statsHandle, do.ddlNotifier))
if config.GetGlobalConfig().Instance.TiDBEnableStatsOwner.Load() {
err := do.statsOwner.CampaignOwner()
if err != nil {
logutil.BgLogger().Warn("campaign owner failed", zap.Error(err))
return err
}
}
do.wg.Run(func() {
do.indexUsageWorker()
}, "indexUsageWorker")
Expand Down Expand Up @@ -2495,13 +2507,6 @@ func (do *Domain) newOwnerManager(prompt, ownerKey string) owner.Manager {
} else {
statsOwner = owner.NewOwnerManager(context.Background(), do.etcdClient, prompt, id, ownerKey)
}
// TODO: Need to do something when err is not nil.
if ownerKey == handle.StatsOwnerKey && config.GetGlobalConfig().Instance.TiDBEnableStatsOwner.Load() {
err := statsOwner.CampaignOwner()
if err != nil {
logutil.BgLogger().Warn("campaign owner failed", zap.Error(err))
}
}
return statsOwner
}

Expand Down