Skip to content

Conversation

tangenta
Copy link
Contributor

@tangenta tangenta commented Nov 14, 2024

What problem does this PR solve?

Issue Number: close #57345

Problem Summary:

The issue was introduced by #31463 and accidentally fixed by #55263. Since #55263 involves a lot of refactoring code, it is not easy to cherry-pick, so I filed this PR for cherry-picking.

What changed and how does it work?

  • Improve retrieval logic. If extractor.SkipRequest is true, we should return the empty result directly.
  • Add integration tests.

This PR doesn't fix the issue, it is only used to cherry-pick

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/needs-triage-completed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 14, 2024
Copy link

tiprow bot commented Nov 14, 2024

Hi @tangenta. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Nov 14, 2024
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Nov 14, 2024
Copy link

ti-chi-bot bot commented Nov 14, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-11-14 03:12:34.627427129 +0000 UTC m=+498716.818296316: ☑️ agreed by hawkingrei.
  • 2024-11-14 03:17:50.381347332 +0000 UTC m=+499032.572216326: ☑️ agreed by CbcWestwolf.

Copy link

codecov bot commented Nov 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.5640%. Comparing base (738adb9) to head (4a59513).
Report is 582 commits behind head on master.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #57370        +/-   ##
================================================
+ Coverage   72.9438%   73.5640%   +0.6201%     
================================================
  Files          1670       1672         +2     
  Lines        461374     464114      +2740     
================================================
+ Hits         336544     341421      +4877     
+ Misses       104127     101992      -2135     
+ Partials      20703      20701         -2     
Flag Coverage Δ
integration 43.4121% <ø> (?)
unit 72.2835% <ø> (-0.0518%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.7673% <ø> (ø)
parser ∅ <ø> (∅)
br 45.1323% <ø> (-0.0100%) ⬇️

Copy link
Collaborator

@Benjamin2037 Benjamin2037 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LTMG

Copy link

ti-chi-bot bot commented Nov 14, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Benjamin2037, CbcWestwolf, hawkingrei

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [Benjamin2037,CbcWestwolf,hawkingrei]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot merged commit f27b3c2 into pingcap:master Nov 14, 2024
23 checks passed
@tangenta tangenta added the needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. label Nov 14, 2024
ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Nov 14, 2024
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #57379.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #59401.
But this PR has conflicts, please resolve them!

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Feb 11, 2025
tangenta added a commit to ti-chi-bot/tidb that referenced this pull request Feb 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

information_schema.columns returns all columns when where clauses are always false
5 participants