-
Notifications
You must be signed in to change notification settings - Fork 6k
planner/core: fix a wrong privilege check for CTE & UPDATE statement #57430
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #57430 +/- ##
================================================
+ Coverage 72.8127% 73.4165% +0.6038%
================================================
Files 1676 1676
Lines 463751 463793 +42
================================================
+ Hits 337670 340501 +2831
+ Misses 105205 102526 -2679
+ Partials 20876 20766 -110
Flags with carried forward coverage won't be shown. Click here to find out more.
|
select id,pid,name,'AAA' fullname from privilege__privileges.tt1 ) | ||
update privilege__privileges.tt1 inner join t_f | ||
set t_f.fullname=t_f.fullname | ||
where tt1.id=t_f.id; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please disconnect u53490 and switch to connection default.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Addressed, PTAL
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Defined2014, hawkingrei The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
/retest |
4c97a75
to
25798fd
Compare
In response to a cherrypick label: new pull request created to branch |
What problem does this PR solve?
Issue Number: close #53490
Problem Summary:
What changed and how does it work?
See #53490 (comment), for statement like:
The privilege check for CTE in the update statement should be avoided.
Check List
Tests
Side effects
Therocially it consumes more CPU to remove the privilege check, but I believe the real world performance will not be impacted.
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.