-
Notifications
You must be signed in to change notification settings - Fork 6k
expression: fix the arg verification for json functions. (#54145) #57567
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
expression: fix the arg verification for json functions. (#54145) #57567
Conversation
Signed-off-by: Yang Keao <[email protected]>
Signed-off-by: Yang Keao <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release-8.5 #57567 +/- ##
================================================
Coverage ? 57.0227%
================================================
Files ? 1770
Lines ? 627286
Branches ? 0
================================================
Hits ? 357696
Misses ? 245567
Partials ? 24023
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
[LGTM Timeline notifier]Timeline:
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bb7133, tangenta, windtalker The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
This is an automated cherry-pick of #54145
What problem does this PR solve?
Issue Number: close #54029, close #54044
Problem Summary:
For some json functions, the arg verification is not implemented correctly:
json_type
, it didn't verify the type of args.For
PREPARE
, the param marker is set to binary string type, which is not expected. This PR will give it a default collation. It will not affect theEXECUTE
, because when it's executing a statement, it'll infer the collation according to the datum (whose collation is set according to the collation settings of the connection).What changed and how does it work?
Check List
Tests
Release note