lightning: remove some NOT NULL constraints on lightning table

[joechenrh]

What problem does this PR solve?

Issue Number: close #57578

Problem Summary:

What changed and how does it work?

#55477 change the behavior of null value insert. To adapt to this change, some NOT NULL constraints have to be removed.

Previous PR just wrongly change INSERT INTO to INSERT IGNORE INTO, which may case data correctness.

Check List

Tests

• Unit test
• Integration test
• Manual test (add detailed scripts or steps below)
• No need to test

  • I checked and no code files have been changed.

Side effects

• Performance regression: Consumes more CPU
• Performance regression: Consumes more Memory
• Breaking backward compatibility

Documentation

• Affects user behaviors
• Contains syntax changes
• Contains variable changes
• Contains experimental features
• Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

[tiprow]

Hi @joechenrh. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.5996%. Comparing base (1c059a1) to head (37d668a).
Report is 8 commits behind head on master.

Additional details and impacted files

@@               Coverage Diff                @@
##             master     #57577        +/-   ##
================================================
+ Coverage   72.8279%   73.5996%   +0.7716%     
================================================
  Files          1676       1706        +30     
  Lines        463631     471652      +8021     
================================================
+ Hits         337653     347134      +9481     
+ Misses       105146     103076      -2070     
- Partials      20832      21442       +610     

Flag	Coverage Δ
integration	46.4049% <ø> (?)
unit	72.1786% <ø> (-0.0435%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
dumpling	52.7673% <ø> (ø)
parser	∅ <ø> (∅)
br	45.4564% <ø> (-0.0061%)	⬇️

---- 🚨 Try these New Features:

• Flaky Tests Detection - Detect and resolve failed and flaky tests
• JS Bundle Analysis - Avoid shipping oversized bundles

[lance6716]

/check-issue-triage-complete

[joechenrh]

/retest

[tiprow]

@joechenrh: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[ti-chi-bot]

@fzzf678: You cannot manually add or delete the reviewing state labels, only I and the tursted members have permission to do so.

In response to removing label named approved.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

[fzzf678]

/approve cancel

[fzzf678]

/lgtm cancel

[fzzf678]

/hold

[fzzf678]

Sry, wrongly approved, unhold this after approved

[joechenrh]

/unhold

[fzzf678]

/unhold

[fzzf678]

/lgtm

[ti-chi-bot]

[LGTM Timeline notifier]

Timeline:

• 2024-11-21 08:17:49.883890011 +0000 UTC m=+106057.503544522: ☑️ agreed by lance6716.
• 2024-11-21 08:49:17.243281335 +0000 UTC m=+107944.862935851: ☑️ agreed by fzzf678.
• 2024-11-21 08:52:02.319363524 +0000 UTC m=+108109.939018039: ✖️🔁 reset by fzzf678.
• 2024-11-21 08:57:23.730631378 +0000 UTC m=+108431.350285895: ☑️ agreed by D3Hunter.
• 2024-11-21 09:06:04.956140805 +0000 UTC m=+108952.575795319: ☑️ agreed by fzzf678.

[ti-chi-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: D3Hunter, fzzf678, lance6716

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• pkg/lightning/OWNERS [D3Hunter,lance6716]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[ti-chi-bot]

In response to a cherrypick label: new pull request created to branch release-8.5: #57600.