Skip to content

Conversation

YangKeao
Copy link
Member

@YangKeao YangKeao commented Nov 26, 2024

What problem does this PR solve?

Issue Number: close #57556, close #57702

Problem Summary:

If the TTL job owner restarts and the TTL table is disabled or dropped, it'll not be removed and will always keep running.

What changed and how does it work?

  1. Also remove the table even when it's current status is not NULL if its heartbeat has timeout.
  2. Shorten the GC period to 10 minutes.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 26, 2024
@YangKeao YangKeao changed the title ttl: fix the issue that DROP TABLE / ALTER TABLE will keep job running ttl: fix the issue that DROP TABLE / ALTER TABLE will keep job running Nov 26, 2024
@hawkingrei
Copy link
Member

/retest

@hawkingrei
Copy link
Member

/test all

Copy link

codecov bot commented Nov 26, 2024

Codecov Report

Attention: Patch coverage is 88.88889% with 1 line in your changes missing coverage. Please review.

Project coverage is 73.8402%. Comparing base (d02d48a) to head (c8fce98).
Report is 34 commits behind head on master.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #57707        +/-   ##
================================================
+ Coverage   72.8318%   73.8402%   +1.0083%     
================================================
  Files          1677       1677                
  Lines        463944     468364      +4420     
================================================
+ Hits         337899     345841      +7942     
+ Misses       105169     101855      -3314     
+ Partials      20876      20668       -208     
Flag Coverage Δ
integration 44.0364% <77.7777%> (?)
unit 72.7075% <77.7777%> (+0.4836%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.7673% <ø> (ø)
parser ∅ <ø> (∅)
br 46.2687% <ø> (+0.7575%) ⬆️

Copy link

tiprow bot commented Nov 26, 2024

@YangKeao: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
fast_test_tiprow c8fce98 link true /test fast_test_tiprow

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@YangKeao YangKeao requested a review from Defined2014 November 27, 2024 05:10
@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Nov 27, 2024
Copy link

ti-chi-bot bot commented Nov 27, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Defined2014, lcwangchao

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [Defined2014,lcwangchao]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Nov 27, 2024
Copy link

ti-chi-bot bot commented Nov 27, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-11-27 06:04:41.279447175 +0000 UTC m=+616468.899101676: ☑️ agreed by lcwangchao.
  • 2024-11-27 06:09:47.148759775 +0000 UTC m=+616774.768414291: ☑️ agreed by Defined2014.

@ti-chi-bot ti-chi-bot bot merged commit ba791ab into pingcap:master Nov 27, 2024
23 of 24 checks passed
@lcwangchao lcwangchao added the needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. label Nov 29, 2024
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.5: #57827.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TTL Job keeps running if the TTL table is dropped or disabled after losing heartbeat TTL GC interval is too high
5 participants