-
Notifications
You must be signed in to change notification settings - Fork 6k
ttl: set a result for timeout scan task during shrinking scan worker #57718
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #57718 +/- ##
================================================
+ Coverage 72.8369% 73.4752% +0.6383%
================================================
Files 1677 1677
Lines 464141 466195 +2054
================================================
+ Hits 338066 342538 +4472
+ Misses 105185 102895 -2290
+ Partials 20890 20762 -128
Flags with carried forward coverage won't be shown. Click here to find out more.
|
/retest |
@lcwangchao: Your lgtm message is repeated, so it is ignored. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/retest |
/retest |
cfae0b3
to
aed83d0
Compare
Signed-off-by: Yang Keao <[email protected]>
efa51f5
to
b744e76
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lcwangchao, zimulala The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
Signed-off-by: Yang Keao <[email protected]>
In response to a cherrypick label: new pull request created to branch |
What problem does this PR solve?
Issue Number: close #57708
Problem Summary:
The result is not set for the scan task when TiDB is shrinking the scan worker and timeout.
What changed and how does it work?
Set a result for the scan task.
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.