Skip to content

Conversation

YangKeao
Copy link
Member

What problem does this PR solve?

Issue Number: close #57708

Problem Summary:

The result is not set for the scan task when TiDB is shrinking the scan worker and timeout.

What changed and how does it work?

Set a result for the scan task.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 26, 2024
@YangKeao YangKeao requested a review from lcwangchao November 26, 2024 10:16
Copy link

codecov bot commented Nov 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.4752%. Comparing base (d0de86b) to head (d64a5f6).
Report is 24 commits behind head on master.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #57718        +/-   ##
================================================
+ Coverage   72.8369%   73.4752%   +0.6383%     
================================================
  Files          1677       1677                
  Lines        464141     466195      +2054     
================================================
+ Hits         338066     342538      +4472     
+ Misses       105185     102895      -2290     
+ Partials      20890      20762       -128     
Flag Coverage Δ
integration 43.3747% <0.0000%> (?)
unit 72.2403% <100.0000%> (-0.0034%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.7673% <ø> (ø)
parser ∅ <ø> (∅)
br 45.7186% <ø> (+0.0240%) ⬆️

@YangKeao
Copy link
Member Author

/retest

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Nov 26, 2024
Copy link

ti-chi-bot bot commented Nov 26, 2024

@lcwangchao: Your lgtm message is repeated, so it is ignored.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@purelind
Copy link
Contributor

/retest

@YangKeao YangKeao requested a review from Defined2014 November 27, 2024 05:10
@YangKeao
Copy link
Member Author

/retest

@YangKeao YangKeao force-pushed the fix-57708 branch 2 times, most recently from efa51f5 to b744e76 Compare November 27, 2024 06:42
@YangKeao YangKeao requested a review from zimulala November 28, 2024 08:03
Copy link
Contributor

@zimulala zimulala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

ti-chi-bot bot commented Nov 28, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lcwangchao, zimulala

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [lcwangchao,zimulala]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Nov 28, 2024
Copy link

ti-chi-bot bot commented Nov 28, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-11-26 11:56:14.248449077 +0000 UTC m=+551161.868103593: ☑️ agreed by lcwangchao.
  • 2024-11-28 08:58:43.974384512 +0000 UTC m=+713311.594039027: ☑️ agreed by zimulala.

@ti-chi-bot ti-chi-bot bot merged commit 0215550 into pingcap:master Nov 28, 2024
20 of 24 checks passed
@lcwangchao lcwangchao added the needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. label Nov 29, 2024
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.5: #57828.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TTL scan task will leak when down scaling the scan workers if it failed to cancel the task.
5 participants