Skip to content

plan: fix a bug when alter table drop column meets insert #5790

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Feb 6, 2018
Merged

plan: fix a bug when alter table drop column meets insert #5790

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
378261e
address comments
jackysp Feb 6, 2018
5f220c7
add test
jackysp Feb 6, 2018
9199d14
make test more useful
jackysp Feb 6, 2018
2e9c6c6
Merge branch 'master' into insert_panic
coocood Feb 6, 2018
a473151
address comments
jackysp Feb 6, 2018
6ad46ca
clearify
jackysp Feb 6, 2018
889a9b9
Merge branch 'master' into insert_panic
zimulala Feb 6, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions expression/expression.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -285,6 +285,9 @@ func TableInfo2SchemaWithDBName(dbName model.CIStr, tbl *model.TableInfo) *Schem
func ColumnInfos2ColumnsWithDBName(dbName, tblName model.CIStr, colInfos []*model.ColumnInfo) []*Column {
columns := make([]*Column, 0, len(colInfos))
for i, col := range colInfos {
if col.State != model.StatePublic {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what about write only column? @zimulala PTAL

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the column is given by the client, we need the Public column.

continue
}
newCol := &Column{
ColName: col.Name,
TblName: tblName,
Expand Down