-
Notifications
You must be signed in to change notification settings - Fork 6k
lightning: fix id too large after parallel import (#57398) #57928
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lightning: fix id too large after parallel import (#57398) #57928
Conversation
Signed-off-by: ti-chi-bot <[email protected]>
/test pull-br-integration-test |
@D3Hunter: No presubmit jobs available for pingcap/[email protected] In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/test pull-br-integration-test |
@D3Hunter: No presubmit jobs available for pingcap/[email protected] In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/retest |
/test pull-br-integration-test |
@D3Hunter: No presubmit jobs available for pingcap/[email protected] In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release-7.5 #57928 +/- ##
================================================
Coverage ? 72.2315%
================================================
Files ? 1415
Lines ? 413077
Branches ? 0
================================================
Hits ? 298372
Misses ? 94755
Partials ? 19950
Flags with carried forward coverage won't be shown. Click here to find out more.
|
lightning ci pass https://do.pingcap.net/jenkins/blue/organizations/jenkins/pingcap%2Ftidb%2Frelease-7.5%2Fpull_br_integration_test/detail/pull_br_integration_test/42/pipeline/424, as no br code changed, won't wait those flaky br cases |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
[LGTM Timeline notifier]Timeline:
|
This reverts commit d91af89.
/retest |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: 3pointer, Benjamin2037, D3Hunter The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@ti-chi-bot: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/retest |
This is an automated cherry-pick of #57398
What problem does this PR solve?
Issue Number: close #56814
Problem Summary:
What changed and how does it work?
previously with parallel import, the auto id after import is the estimated ones even though there are IDs inside the data source file, we change to the ones inside the data source file to avoid next auto id too large
to do this, we need to save different values for different auto id in checkpoint
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.