Skip to content

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #57398

What problem does this PR solve?

Issue Number: close #56814

Problem Summary:

What changed and how does it work?

previously with parallel import, the auto id after import is the estimated ones even though there are IDs inside the data source file, we change to the ones inside the data source file to avoid next auto id too large

to do this, we need to save different values for different auto id in checkpoint

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
    • parallel import with 2 instances, next id is the max id in data files + 1
    • open parallel import, but start instance B after the first instance finish, so we can see B is checksuming existing data, and success
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. type/cherry-pick-for-release-7.5 This PR is cherry-picked to release-7.5 from a source PR. labels Dec 3, 2024
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Dec 3, 2024
@D3Hunter
Copy link
Contributor

D3Hunter commented Dec 3, 2024

/test pull-br-integration-test

Copy link

tiprow bot commented Dec 3, 2024

@D3Hunter: No presubmit jobs available for pingcap/[email protected]

In response to this:

/test pull-br-integration-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@D3Hunter
Copy link
Contributor

D3Hunter commented Dec 3, 2024

/test pull-br-integration-test

Copy link

tiprow bot commented Dec 3, 2024

@D3Hunter: No presubmit jobs available for pingcap/[email protected]

In response to this:

/test pull-br-integration-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@D3Hunter
Copy link
Contributor

D3Hunter commented Dec 3, 2024

/retest

@D3Hunter
Copy link
Contributor

D3Hunter commented Dec 3, 2024

/test pull-br-integration-test

Copy link

tiprow bot commented Dec 3, 2024

@D3Hunter: No presubmit jobs available for pingcap/[email protected]

In response to this:

/test pull-br-integration-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

codecov bot commented Dec 3, 2024

Codecov Report

Attention: Patch coverage is 65.77778% with 77 lines in your changes missing coverage. Please review.

Please upload report for BASE (release-7.5@bf0766b). Learn more about missing BASE report.

Additional details and impacted files
@@               Coverage Diff                @@
##             release-7.5     #57928   +/-   ##
================================================
  Coverage               ?   72.2315%           
================================================
  Files                  ?       1415           
  Lines                  ?     413077           
  Branches               ?          0           
================================================
  Hits                   ?     298372           
  Misses                 ?      94755           
  Partials               ?      19950           
Flag Coverage Δ
unit 72.2315% <65.7777%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.9400% <0.0000%> (?)
parser ∅ <0.0000%> (?)
br 53.5696% <0.0000%> (?)

@D3Hunter
Copy link
Contributor

D3Hunter commented Dec 3, 2024

Copy link
Collaborator

@Benjamin2037 Benjamin2037 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Dec 6, 2024
Copy link

ti-chi-bot bot commented Dec 6, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-12-03 09:34:07.984194408 +0000 UTC m=+1147435.603848924: ☑️ agreed by D3Hunter.
  • 2024-12-06 02:45:43.024083124 +0000 UTC m=+1382130.643737641: ☑️ agreed by Benjamin2037.

This reverts commit d91af89.
@D3Hunter
Copy link
Contributor

D3Hunter commented Dec 6, 2024

/retest

Copy link

ti-chi-bot bot commented Dec 6, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 3pointer, Benjamin2037, D3Hunter

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Dec 6, 2024
Copy link

ti-chi-bot bot commented Dec 6, 2024

@ti-chi-bot: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-br-integration-test 068de3d link false /test pull-br-integration-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@D3Hunter
Copy link
Contributor

D3Hunter commented Dec 6, 2024

/retest

@ti-chi-bot ti-chi-bot bot merged commit f8d5c54 into pingcap:release-7.5 Dec 6, 2024
17 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. type/cherry-pick-for-release-7.5 This PR is cherry-picked to release-7.5 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants