Skip to content

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #57967

What problem does this PR solve?

Issue Number: close #57816

Problem Summary:

The timeout is only 1 second for fetching the system table from tiflash instance. When there are thousand of table with tiflash replica under the disaggregated compute and storage arch, fetching the metadata require accessing files stored on S3. Under that situation, the 1 second is too short for timeout.

// send request to tiflash, timeout is 1s
instanceID := e.instanceIDs[e.instanceIdx]
resp, err := tikvStore.GetTiKVClient().SendRequest(ctx, instanceID, &request, time.Second)
if err != nil {
return nil, errors.Trace(err)
}

What changed and how does it work?

Fetching the info with about 5000 tables and 10 TiB data under disaggregated arch take about 3 seconds. Enlarge the timeout for fetching data from each tiflash instance to be 5 minutes is long enough.

And I've tested that the query respect max_execution_time.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
    Inject an failpoint in TiFlash to stop responsing the system table query and make the tidb query on TIFLASH_TABLES timeout
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

Fix an issue that in the disaggregated storage and compute architecture, executing queries on tiflash related system tables might timeout

@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. type/cherry-pick-for-release-8.1 This PR is cherry-picked to release-8.1 from a source PR. labels Dec 4, 2024
@JaySon-Huang
Copy link
Contributor

@guo-shaoge @lidezhu PTAL

Copy link

codecov bot commented Dec 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (release-8.1@8e150a5). Learn more about missing BASE report.

Additional details and impacted files
@@               Coverage Diff                @@
##             release-8.1     #57978   +/-   ##
================================================
  Coverage               ?   71.1923%           
================================================
  Files                  ?       1467           
  Lines                  ?     423412           
  Branches               ?          0           
================================================
  Hits                   ?     301437           
  Misses                 ?     101463           
  Partials               ?      20512           
Flag Coverage Δ
unit 71.1923% <100.0000%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.9656% <0.0000%> (?)
parser ∅ <0.0000%> (?)
br 41.2954% <0.0000%> (?)

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Dec 5, 2024
Copy link

ti-chi-bot bot commented Dec 5, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: guo-shaoge, lidezhu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Dec 5, 2024
Copy link

ti-chi-bot bot commented Dec 5, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-12-05 02:18:06.515968782 +0000 UTC m=+1294074.135623291: ☑️ agreed by lidezhu.
  • 2024-12-05 02:18:23.855166817 +0000 UTC m=+1294091.474821330: ☑️ agreed by guo-shaoge.

@ti-chi-bot ti-chi-bot bot merged commit c4d75ee into pingcap:release-8.1 Dec 5, 2024
18 checks passed
@JaySon-Huang JaySon-Huang deleted the cherry-pick-57967-to-release-8.1 branch December 5, 2024 02:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. type/cherry-pick-for-release-8.1 This PR is cherry-picked to release-8.1 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants