executor: Enlarge the timeout for fetching TiFlash system tables (#57967) #57978
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated cherry-pick of #57967
What problem does this PR solve?
Issue Number: close #57816
Problem Summary:
The timeout is only 1 second for fetching the system table from tiflash instance. When there are thousand of table with tiflash replica under the disaggregated compute and storage arch, fetching the metadata require accessing files stored on S3. Under that situation, the 1 second is too short for timeout.
tidb/pkg/executor/infoschema_reader.go
Lines 3484 to 3489 in 9812d85
What changed and how does it work?
Fetching the info with about 5000 tables and 10 TiB data under disaggregated arch take about 3 seconds. Enlarge the timeout for fetching data from each tiflash instance to be 5 minutes is long enough.
And I've tested that the query respect
max_execution_time
.Check List
Tests
Inject an failpoint in TiFlash to stop responsing the system table query and make the tidb query on
TIFLASH_TABLES
timeoutSide effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.