Skip to content

Conversation

0xPoe
Copy link
Member

@0xPoe 0xPoe commented Dec 5, 2024

What problem does this PR solve?

Issue Number: ref #57871

Problem Summary:

What changed and how does it work?

Split from #57872

  1. Renamed the handler to "subscriber" to avoid conflict with an existing handler in this package.
  2. Correctly handled the schema drop event.

This will be integrated into my next PR, so additional tests will be added. We plan to update the tests in subsequent PRs.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added the release-note-none Denotes a PR that doesn't merit a release note. label Dec 5, 2024
@0xPoe 0xPoe requested a review from lance6716 December 5, 2024 08:07
@ti-chi-bot ti-chi-bot bot added sig/planner SIG: Planner size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 5, 2024
@0xPoe 0xPoe requested a review from qw4990 December 5, 2024 08:07
Copy link
Member Author

@0xPoe 0xPoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔢 Self-check (PR reviewed by myself and ready for feedback.)

@0xPoe 0xPoe requested a review from elsa0520 December 5, 2024 08:10
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Dec 5, 2024
Copy link

codecov bot commented Dec 5, 2024

Codecov Report

Attention: Patch coverage is 0% with 15 lines in your changes missing coverage. Please review.

Project coverage is 73.8467%. Comparing base (30069c5) to head (baebd82).
Report is 121 commits behind head on master.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #58009        +/-   ##
================================================
+ Coverage   73.1633%   73.8467%   +0.6833%     
================================================
  Files          1674       1704        +30     
  Lines        461261     469345      +8084     
================================================
+ Hits         337474     346596      +9122     
+ Misses       103041     101276      -1765     
- Partials      20746      21473       +727     
Flag Coverage Δ
integration 46.0784% <0.0000%> (?)
unit 72.3186% <0.0000%> (+0.0289%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.6910% <ø> (ø)
parser ∅ <ø> (∅)
br 45.9743% <ø> (-0.0331%) ⬇️

Copy link

ti-chi-bot bot commented Dec 5, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lance6716, qw4990

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added approved lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Dec 5, 2024
Copy link

ti-chi-bot bot commented Dec 5, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-12-05 08:22:07.493605997 +0000 UTC m=+1315915.113260510: ☑️ agreed by lance6716.
  • 2024-12-05 08:26:10.968142384 +0000 UTC m=+1316158.587796899: ☑️ agreed by qw4990.

@ti-chi-bot ti-chi-bot bot merged commit 5a25eea into pingcap:master Dec 5, 2024
25 checks passed
0xPoe added a commit to ti-chi-bot/tidb that referenced this pull request Dec 20, 2024
0xPoe added a commit to ti-chi-bot/tidb that referenced this pull request Dec 20, 2024
@ti-chi-bot ti-chi-bot bot added the needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. label Dec 23, 2024
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.5: #58457.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants