-
Notifications
You must be signed in to change notification settings - Fork 6k
br: make table existence check unified on different br client (#58211) #58244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
br: make table existence check unified on different br client (#58211) #58244
Conversation
Signed-off-by: ti-chi-bot <[email protected]>
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: BornChanger, YuJuncen The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
/retest |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release-8.1 #58244 +/- ##
================================================
Coverage ? 71.2308%
================================================
Files ? 1468
Lines ? 423784
Branches ? 0
================================================
Hits ? 301865
Misses ? 101411
Partials ? 20508
Flags with carried forward coverage won't be shown. Click here to find out more.
|
/retest |
@ti-chi-bot: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
This is an automated cherry-pick of #58211
What problem does this PR solve?
Issue Number: close #58168
Problem Summary:
What changed and how does it work?
Remove the client check of
tableExistenceCheck
, now it works on both sql and cli client.Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.