planner: fix possible read-write DATA RACE on Instance Plan Cache

[qw4990]

What problem does this PR solve?

Issue Number: close #58318

Problem Summary: planner: fix possible read-write DATA RACE on Instance Plan Cache

What changed and how does it work?

Check List

Tests

• Unit test
• Integration test
• Manual test (add detailed scripts or steps below)
• No need to test

  • I checked and no code files have been changed.

Side effects

• Performance regression: Consumes more CPU
• Performance regression: Consumes more Memory
• Breaking backward compatibility

Documentation

• Affects user behaviors
• Contains syntax changes
• Contains variable changes
• Contains experimental features
• Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

[tiprow]

Hi @qw4990. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[hawkingrei]

/ok-to-test

[ti-chi-bot]

[LGTM Timeline notifier]

Timeline:

• 2024-12-17 07:05:34.134828101 +0000 UTC m=+940524.223630644: ☑️ agreed by time-and-fate.
• 2024-12-17 07:11:59.418827137 +0000 UTC m=+940909.507629680: ☑️ agreed by AilinKid.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.8154%. Comparing base (aec0fc5) to head (388d297).
Report is 477 commits behind head on master.

Additional details and impacted files

@@               Coverage Diff                @@
##             master     #58328        +/-   ##
================================================
+ Coverage   73.2097%   73.8154%   +0.6057%     
================================================
  Files          1679       1711        +32     
  Lines        462339     476010     +13671     
================================================
+ Hits         338477     351369     +12892     
+ Misses       103082     102996        -86     
- Partials      20780      21645       +865     

Flag	Coverage Δ
integration	46.1248% <28.5714%> (?)
unit	72.3259% <100.0000%> (-0.0185%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
dumpling	52.6910% <ø> (ø)
parser	∅ <ø> (∅)
br	46.0049% <ø> (-0.0271%)	⬇️

🚀 New features to boost your workflow:

• ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[qw4990]

/test check-dev2

[tiprow]

@qw4990: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

• /test fast_test_tiprow
• /test fast_test_tiprow_ddlargsv1
• /test tidb_parser_test

Use /test all to run the following jobs that were automatically triggered:

• fast_test_tiprow
• tidb_parser_test

In response to this:

/test check-dev2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[qw4990]

/test unit-test

[tiprow]

@qw4990: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

• /test fast_test_tiprow
• /test fast_test_tiprow_ddlargsv1
• /test tidb_parser_test

Use /test all to run the following jobs that were automatically triggered:

• fast_test_tiprow
• tidb_parser_test

In response to this:

/test unit-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[qw4990]

/test unit-test

[tiprow]

@qw4990: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

• /test fast_test_tiprow
• /test fast_test_tiprow_ddlargsv1
• /test tidb_parser_test

Use /test all to run the following jobs that were automatically triggered:

• fast_test_tiprow
• tidb_parser_test

In response to this:

/test unit-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[qw4990]

/retest

[qw4990]

/test pull-integration-ddl-test

[tiprow]

@qw4990: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

• /test fast_test_tiprow
• /test fast_test_tiprow_ddlargsv1
• /test tidb_parser_test

Use /test all to run the following jobs that were automatically triggered:

• fast_test_tiprow
• tidb_parser_test

In response to this:

/test pull-integration-ddl-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[qw4990]

/test unit-test

[tiprow]

@qw4990: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

• /test fast_test_tiprow
• /test fast_test_tiprow_ddlargsv1
• /test tidb_parser_test

Use /test all to run the following jobs that were automatically triggered:

• fast_test_tiprow
• tidb_parser_test

In response to this:

/test unit-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[hawkingrei]

/retest

[qw4990]

/test unit-test

[tiprow]

@qw4990: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

• /test fast_test_tiprow
• /test fast_test_tiprow_ddlargsv1
• /test tidb_parser_test

Use /test all to run the following jobs that were automatically triggered:

• fast_test_tiprow
• tidb_parser_test

In response to this:

/test unit-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[qw4990]

/test unit-test

[tiprow]

@qw4990: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

• /test fast_test_tiprow
• /test fast_test_tiprow_ddlargsv1
• /test tidb_parser_test

Use /test all to run the following jobs that were automatically triggered:

• fast_test_tiprow
• tidb_parser_test

In response to this:

/test unit-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[qw4990]

/test unit-test

[tiprow]

@qw4990: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

• /test fast_test_tiprow
• /test fast_test_tiprow_ddlargsv1
• /test tidb_parser_test

Use /test all to run the following jobs that were automatically triggered:

• fast_test_tiprow
• tidb_parser_test

In response to this:

/test unit-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[windtalker]

lgtm

[ti-chi-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AilinKid, hawkingrei, time-and-fate, windtalker

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• pkg/expression/OWNERS [windtalker]
• pkg/planner/OWNERS [AilinKid,hawkingrei,time-and-fate]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[hawkingrei]

/cherrypick release-8.5

[ti-chi-bot]

@hawkingrei: new pull request created to branch release-8.5: #61710.
But this PR has conflicts, please resolve them!

In response to this:

/cherrypick release-8.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.