Skip to content

domain: change some stats log level as WARN (#58316) #58551

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 27, 2024
Merged

domain: change some stats log level as WARN (#58316) #58551

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c78e64b
This is an automated cherry-pick of #58316
hawkingrei Dec 17, 2024
9ccccfe
update
hawkingrei Dec 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions domain/domain.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2067,7 +2067,7 @@
case <-deltaUpdateTicker.C:
err := statsHandle.DumpStatsDeltaToKV(handle.DumpDelta)
if err != nil {
logutil.BgLogger().Debug("dump stats delta failed", zap.Error(err))
logutil.BgLogger().Warn("dump stats delta failed", zap.Error(err))

Check warning on line 2070 in domain/domain.go

View check run for this annotation

Codecov / codecov/patch

domain/domain.go#L2070 

Added line #L2070 was not covered by tests
}
statsHandle.UpdateErrorRate(do.InfoSchema())
case <-loadFeedbackTicker.C:
Expand All @@ -2077,30 +2077,30 @@
}
err := statsHandle.HandleUpdateStats(do.InfoSchema())
if err != nil {
logutil.BgLogger().Debug("update stats using feedback failed", zap.Error(err))
logutil.BgLogger().Warn("update stats using feedback failed", zap.Error(err))

Check warning on line 2080 in domain/domain.go

View check run for this annotation

Codecov / codecov/patch

domain/domain.go#L2080 

Added line #L2080 was not covered by tests
}
case <-loadLockedTablesTicker.C:
err := statsHandle.LoadLockedTables()
if err != nil {
logutil.BgLogger().Debug("load locked table failed", zap.Error(err))
logutil.BgLogger().Warn("load locked table failed", zap.Error(err))

Check warning on line 2085 in domain/domain.go

View check run for this annotation

Codecov / codecov/patch

domain/domain.go#L2085 

Added line #L2085 was not covered by tests
}
case <-dumpFeedbackTicker.C:
err := statsHandle.DumpStatsFeedbackToKV()
if err != nil {
logutil.BgLogger().Debug("dump stats feedback failed", zap.Error(err))
logutil.BgLogger().Warn("dump stats feedback failed", zap.Error(err))

Check warning on line 2090 in domain/domain.go

View check run for this annotation

Codecov / codecov/patch

domain/domain.go#L2090 

Added line #L2090 was not covered by tests
}
case <-gcStatsTicker.C:
if !owner.IsOwner() {
continue
}
err := statsHandle.GCStats(do.InfoSchema(), do.DDL().GetLease())
if err != nil {
logutil.BgLogger().Debug("GC stats failed", zap.Error(err))
logutil.BgLogger().Warn("GC stats failed", zap.Error(err))

Check warning on line 2098 in domain/domain.go

View check run for this annotation

Codecov / codecov/patch

domain/domain.go#L2098 

Added line #L2098 was not covered by tests
}
case <-dumpColStatsUsageTicker.C:
err := statsHandle.DumpColStatsUsageToKV()
if err != nil {
logutil.BgLogger().Debug("dump column stats usage failed", zap.Error(err))
logutil.BgLogger().Warn("dump column stats usage failed", zap.Error(err))

Check warning on line 2103 in domain/domain.go

View check run for this annotation

Codecov / codecov/patch

domain/domain.go#L2103 

Added line #L2103 was not covered by tests
}

case <-readMemTricker.C:
Expand Down
Loading