-
Notifications
You must be signed in to change notification settings - Fork 6k
import-into: support running with 1 thread when using global sort #58572
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: joccau <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #58572 +/- ##
================================================
+ Coverage 72.9581% 73.3884% +0.4302%
================================================
Files 1697 1697
Lines 468911 468932 +21
================================================
+ Hits 342109 344142 +2033
+ Misses 105737 103739 -1998
+ Partials 21065 21051 -14
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Signed-off-by: joccau <[email protected]>
Signed-off-by: joccau <[email protected]>
Signed-off-by: joccau <[email protected]>
86b5522
to
1c99267
Compare
Signed-off-by: joccau <[email protected]>
c7b1279
to
0c0396b
Compare
/test pull-lightning-integration-test |
@joccau: The specified target(s) for
Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Signed-off-by: joccau <[email protected]>
/test unit-test |
@joccau: The specified target(s) for
Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/test pull-lightning-integration-test |
If the goal is during the whole IMPORT INTO only ~100% CPU is used, I think your internal test report can't achieve it. |
Signed-off-by: joccau <[email protected]>
/hold this PR and related test hasn't reproduced the OOM we meet before, so there is no optimization for memory |
/unhold |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rest lgtm
Signed-off-by: joccau <[email protected]>
Signed-off-by: joccau <[email protected]>
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: D3Hunter, lance6716 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test check-dev2 |
@joccau: The specified target(s) for
Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
What problem does this PR solve?
Issue Number: close #58680
Problem Summary:
What changed and how does it work?
import into
can be run with the option of thread=1Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.