br: fix go leak when nothing to restore

[Tristan1900]

What problem does this PR solve?

Issue Number: close #58624

Problem Summary:

What changed and how does it work?

Remove the early return, found 2 issues related to it, so better go through the entire restore process to avoid future surprises.

1. recent change makes the ctx in GoSwitchToImportMode not inherit from the main ctx, thus when main ctx cancelled, the go routine won't end, and the manual cleanup logic wasn't called when restoring an empty backup, leading to a go routine leak found in int test
2. recent change creates connection in NewSnapFileImporter and store it into a closure rc.getRestorerFn, early return didn't call the closure so couldn't free up the connection, causing another go leak.

Check List

Tests

• Unit test
• Integration test
• Manual test (add detailed scripts or steps below)
• No need to test

  • I checked and no code files have been changed.

Side effects

• Performance regression: Consumes more CPU
• Performance regression: Consumes more Memory
• Breaking backward compatibility

Documentation

• Affects user behaviors
• Contains syntax changes
• Contains variable changes
• Contains experimental features
• Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

[tiprow]

Hi @Tristan1900. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[Tristan1900]

it should go though to the end of method and get set anyway

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.6101%. Comparing base (c34a6b6) to head (3dd5d76).
Report is 162 commits behind head on master.

Additional details and impacted files

@@               Coverage Diff                @@
##             master     #58626        +/-   ##
================================================
+ Coverage   72.9965%   74.6101%   +1.6135%     
================================================
  Files          1683       1699        +16     
  Lines        465963     466064       +101     
================================================
+ Hits         340137     347731      +7594     
+ Misses       104867      96644      -8223     
- Partials      20959      21689       +730     

Flag	Coverage Δ
integration	45.9920% <100.0000%> (?)
unit	72.1850% <0.0000%> (+0.0019%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
dumpling	52.6910% <ø> (ø)
parser	∅ <ø> (∅)
br	61.0822% <100.0000%> (+15.7711%)	⬆️

[Tristan1900]

/assign @3pointer

[BornChanger]

it's strange to add comments at the rear of a code block.

[ti-chi-bot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: RidRisR
Once this PR has been reviewed and has the lgtm label, please ask for approval from 3pointer, ensuring that each of them provides their approval before proceeding. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• br/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[ti-chi-bot]

[LGTM Timeline notifier]

Timeline:

• 2025-02-14 02:53:00.777325358 +0000 UTC m=+584223.173547420: ☑️ agreed by RidRisR.

[Tristan1900]

close as fixed as part of the change in #57394