planner: Ensure index without stats survives for skyling pruning | tidb-test=pr/2465

[terry1purcell]

What problem does this PR solve?

Issue Number: close #57948

Problem Summary:

What changed and how does it work?

Enhanced CompareCandidates logic within SkyLinePruning to allow an index without statistics to survive so that it can be preferenced above a tablescan if it has more equals predicates than other available choices.

Check List

Tests

• Unit test
• Integration test
• Manual test (add detailed scripts or steps below)
• No need to test

  • I checked and no code files have been changed.

Side effects

• Performance regression: Consumes more CPU
• Performance regression: Consumes more Memory
• Breaking backward compatibility

Documentation

• Affects user behaviors
• Contains syntax changes
• Contains variable changes
• Contains experimental features
• Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

[tiprow]

Hi @terry1purcell. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[codecov]

Codecov Report

Attention: Patch coverage is 90.69767% with 8 lines in your changes missing coverage. Please review.

Project coverage is 73.4272%. Comparing base (5ed9e63) to head (549a7bf).
Report is 51 commits behind head on master.

Additional details and impacted files

@@               Coverage Diff                @@
##             master     #58729        +/-   ##
================================================
+ Coverage   73.0400%   73.4272%   +0.3872%     
================================================
  Files          1684       1684                
  Lines        465705     468311      +2606     
================================================
+ Hits         340151     343868      +3717     
+ Misses       104635     103414      -1221     
- Partials      20919      21029       +110     

Flag	Coverage Δ
integration	42.7988% <65.1162%> (?)
unit	72.2072% <90.6976%> (-0.0215%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
dumpling	52.6910% <ø> (ø)
parser	∅ <ø> (∅)
br	45.1504% <ø> (-0.1593%)	⬇️

[terry1purcell]

/retest

[tiprow]

@terry1purcell: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[bb7133]

/retest

[qw4990]

LGTM, nice work!

[time-and-fate]

Others LGTM.

[ti-chi-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qw4990, time-and-fate

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• pkg/planner/OWNERS [qw4990,time-and-fate]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[ti-chi-bot]

[LGTM Timeline notifier]

Timeline:

• 2025-01-21 08:57:19.739273395 +0000 UTC m=+171167.070192796: ☑️ agreed by qw4990.
• 2025-01-21 16:31:56.883037381 +0000 UTC m=+198444.213956784: ☑️ agreed by time-and-fate.

[terry1purcell]

/cherry-pick release-8.5

[ti-chi-bot]

@terry1purcell: new pull request created to branch release-8.5: #59227.

In response to this:

/cherry-pick release-8.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

[terry1purcell]

/cherrypick release-8.5

[ti-chi-bot]

@terry1purcell: new pull request could not be created: failed to create pull request against pingcap/tidb#release-8.5 from head ti-chi-bot:cherry-pick-58729-to-release-8.5: status code 422 not one of [201], body: {"message":"Validation Failed","errors":[{"resource":"PullRequest","code":"custom","message":"A pull request already exists for ti-chi-bot:cherry-pick-58729-to-release-8.5."}],"documentation_url":"https://docs.github.com/rest/pulls/pulls#create-a-pull-request","status":"422"}

In response to this:

/cherrypick release-8.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.