Skip to content

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #57703

What problem does this PR solve?

Issue Number: close #57990

What changed and how does it work?

This PR makes some changes:

  1. Flush expired rows not deleted in delWorker before it stops.
  2. When stopping a scanWorker, wait for all rows to be deleted before writing its state to task meta.
  3. Mark the status of a task back to waiting when its worker stops to ensure it can be obtained by other instances again.
  4. When task heartbeating, merge the current statistics and the old one that recovered from the task meta.
  5. Add more logs.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot force-pushed the cherry-pick-57703-to-release-8.5 branch from 0abfcc4 to b2a4347 Compare January 7, 2025 14:40
@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. type/cherry-pick-for-release-8.5 This PR is cherry-picked to release-8.5 from a source PR. labels Jan 7, 2025
@ti-chi-bot ti-chi-bot force-pushed the cherry-pick-57703-to-release-8.5 branch from b2a4347 to 9d8b73f Compare January 7, 2025 14:41
Copy link

ti-chi-bot bot commented Jan 7, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from lcwangchao, ensuring that each of them provides their approval before proceeding. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

ti-chi-bot bot commented Jan 7, 2025

@ti-chi-bot: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
idc-jenkins-ci-tidb/unit-test 9d8b73f link true /test unit-test
idc-jenkins-ci-tidb/build 9d8b73f link true /test build
idc-jenkins-ci-tidb/check_dev 9d8b73f link true /test check-dev
idc-jenkins-ci-tidb/check_dev_2 9d8b73f link true /test check-dev2

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@lcwangchao lcwangchao closed this Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick-approved Cherry pick PR approved by release team. release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. type/cherry-pick-for-release-8.5 This PR is cherry-picked to release-8.5 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants