br/stream: allow pitr to create oversized indices (#58433)

[michaelmdeng]

What problem does this PR solve?

Issue Number: close #58430

Manual cherry-pick of #58433 to 8.1 release, superceding #58528

Problem Summary: During restoring, the internal config of BR wasn't updated. It may reject all indices longer than the default config (3072) though the target cluster modified this config.

What changed and how does it work?

This updates the TiDB config of the BR internal TiDB instance during restoring incremental data.

Check List

Tests

• Unit test
• Integration test
• Manual test (add detailed scripts or steps below)
• No need to test

  • I checked and no code files have been changed.

Side effects

• Performance regression: Consumes more CPU
• Performance regression: Consumes more Memory
• Breaking backward compatibility

Documentation

• Affects user behaviors
• Contains syntax changes
• Contains variable changes
• Contains experimental features
• Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

Fixed a bug that caused cannot restore index created during log backup if it is longer than `3072`.

[ti-chi-bot]

Hi @michaelmdeng. Thanks for your PR.

I'm waiting for a pingcap member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[tiprow]

Hi @michaelmdeng. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[Tristan1900]

/ok-to-test

[YuJuncen]

Thanks!

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Please upload report for BASE (release-8.1@207b06b). Learn more about missing BASE report.

Additional details and impacted files

@@               Coverage Diff                @@
##             release-8.1     #58812   +/-   ##
================================================
  Coverage               ?   71.3414%           
================================================
  Files                  ?       1468           
  Lines                  ?     424722           
  Branches               ?          0           
================================================
  Hits                   ?     303003           
  Misses                 ?     101264           
  Partials               ?      20455           

Flag	Coverage Δ
unit	71.3414% <0.0000%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
dumpling	52.9656% <0.0000%> (?)
parser	∅ <0.0000%> (?)
br	41.3301% <0.0000%> (?)

[ti-chi-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BornChanger, YuJuncen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• br/OWNERS [BornChanger,YuJuncen]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[ti-chi-bot]

[LGTM Timeline notifier]

Timeline:

• 2025-01-09 02:12:22.700128114 +0000 UTC m=+406085.988959819: ☑️ agreed by YuJuncen.
• 2025-01-10 09:10:57.604215379 +0000 UTC m=+517600.893047085: ☑️ agreed by BornChanger.

[BornChanger]

/retest