Skip to content

Conversation

hawkingrei
Copy link
Member

@hawkingrei hawkingrei commented Jan 13, 2025

What problem does this PR solve?

Issue Number: close #58865

Problem Summary:

What changed and how does it work?

when drop index happen during the async load. it will happen the panic.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)

with 1m tables's DDL and DML, this problem will not happen again.

  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue do-not-merge/needs-tests-checked release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 13, 2025
@ti-chi-bot ti-chi-bot bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 13, 2025
Copy link

codecov bot commented Jan 13, 2025

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 73.8445%. Comparing base (e8f6026) to head (ccdb985).
Report is 3 commits behind head on master.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #58887        +/-   ##
================================================
+ Coverage   73.1210%   73.8445%   +0.7235%     
================================================
  Files          1680       1710        +30     
  Lines        464549     472888      +8339     
================================================
+ Hits         339683     349202      +9519     
+ Misses       104015     102163      -1852     
- Partials      20851      21523       +672     
Flag Coverage Δ
integration 45.9362% <0.0000%> (?)
unit 72.4008% <0.0000%> (+0.0828%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.6910% <ø> (ø)
parser ∅ <ø> (∅)
br 45.4343% <ø> (+0.0266%) ⬆️

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jan 13, 2025
@hawkingrei
Copy link
Member Author

/hold

wait for intergration test

@ti-chi-bot ti-chi-bot bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 13, 2025
@hawkingrei
Copy link
Member Author

/unhold

@ti-chi-bot ti-chi-bot bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 15, 2025
Copy link

ti-chi-bot bot commented Jan 15, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AilinKid, winoros

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jan 15, 2025
Copy link

ti-chi-bot bot commented Jan 15, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-01-13 10:03:30.928762986 +0000 UTC m=+779954.217594691: ☑️ agreed by AilinKid.
  • 2025-01-15 08:43:25.545139363 +0000 UTC m=+108077.000185510: ☑️ agreed by winoros.

@hawkingrei hawkingrei added the needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. label Jan 15, 2025
@hawkingrei
Copy link
Member Author

/retest

@ti-chi-bot ti-chi-bot bot merged commit 6180fb7 into pingcap:master Jan 15, 2025
25 checks passed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.5: #58957.

@hawkingrei
Copy link
Member Author

/cherrypick release-8.5-20250114-v8.5.0

@ti-chi-bot
Copy link
Member

@hawkingrei: new pull request created to branch release-8.5-20250114-v8.5.0: #58964.

In response to this:

/cherrypick release-8.5-20250114-v8.5.0

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stats panic invalid memory address or nil pointer dereference
4 participants