Skip to content

Conversation

Defined2014
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #59000

Problem Summary:

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jan 17, 2025
Copy link

tiprow bot commented Jan 17, 2025

Hi @Defined2014. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@@ -8197,7 +8197,7 @@ FunctionCallKeyword:
{
$$ = &ast.FuncCallExpr{FnName: ast.NewCIStr(ast.InsertFunc), Args: $3.([]ast.ExprNode)}
}
| "MOD" '(' BitExpr ',' BitExpr ')'
| "MOD" '(' Expression ',' Expression ')'
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link

codecov bot commented Jan 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.4908%. Comparing base (39cdcbf) to head (180a0e2).
Report is 8 commits behind head on master.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #59017        +/-   ##
================================================
+ Coverage   73.0651%   73.4908%   +0.4257%     
================================================
  Files          1690       1690                
  Lines        467071     467122        +51     
================================================
+ Hits         341266     343292      +2026     
+ Misses       104844     102872      -1972     
+ Partials      20961      20958         -3     
Flag Coverage Δ
integration 42.9119% <ø> (?)
unit 72.2562% <100.0000%> (-0.0085%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.6910% <ø> (ø)
parser ∅ <ø> (∅)
br 45.4829% <ø> (-0.0058%) ⬇️

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Feb 8, 2025
@Defined2014 Defined2014 requested a review from bb7133 February 8, 2025 05:30
Copy link
Member

@bb7133 bb7133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Feb 10, 2025
Copy link

ti-chi-bot bot commented Feb 10, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-02-08 05:29:15.627572863 +0000 UTC m=+75198.023794920: ☑️ agreed by xhebox.
  • 2025-02-10 06:16:22.844344699 +0000 UTC m=+250825.240566754: ☑️ agreed by bb7133.

Copy link

ti-chi-bot bot commented Feb 10, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bb7133, xhebox, yudongusa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Feb 10, 2025
@ti-chi-bot ti-chi-bot bot merged commit cdb5838 into pingcap:master Feb 10, 2025
24 checks passed
@Defined2014 Defined2014 deleted the fix-59000 branch February 10, 2025 07:34
zeminzhou pushed a commit to zeminzhou/tidb that referenced this pull request May 6, 2025
budney pushed a commit to budney/tidb that referenced this pull request May 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unexpected error in Mod function
4 participants