-
Notifications
You must be signed in to change notification settings - Fork 6k
br: concurrently repairing indexes #59159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
br: concurrently repairing indexes #59159
Conversation
Signed-off-by: Jianjun Liao <[email protected]>
Hi @Leavrth. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #59159 +/- ##
================================================
+ Coverage 73.0489% 74.7315% +1.6826%
================================================
Files 1684 1706 +22
Lines 466386 484027 +17641
================================================
+ Hits 340690 361721 +21031
+ Misses 104751 100013 -4738
- Partials 20945 22293 +1348
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Signed-off-by: Jianjun Liao <[email protected]>
Signed-off-by: Jianjun Liao <[email protected]>
br/pkg/restore/log_client/client.go
Outdated
w := console.StartProgressBar(progressTitle, glue.OnlyOneTask) | ||
defer w.Close() | ||
sessionCount := defaultRepairIndexSessionCount | ||
unsafeSessions, err := createSessions(ctx, g, rc.dom.Store(), sessionCount) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
...Actually this is safe if you only use these sessions in the function and not share them
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rest LGTM
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: 3pointer, BornChanger The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
/hold |
Signed-off-by: Jianjun Liao <[email protected]>
/unhold |
/ok-to-test |
Signed-off-by: Jianjun Liao <[email protected]>
Signed-off-by: ti-chi-bot <[email protected]>
In response to a cherrypick label: new pull request created to branch |
What problem does this PR solve?
Issue Number: close #59158
Problem Summary:
Currently BR repairs ingest indexes (delete + add index) one by one, which can not take advantage of the DDL concurrent adding indexes feature.
What changed and how does it work?
Create more sessions to repair ingest indexes concurrently.
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.