Skip to content

Conversation

Leavrth
Copy link
Contributor

@Leavrth Leavrth commented Jan 23, 2025

What problem does this PR solve?

Issue Number: close #59158

Problem Summary:
Currently BR repairs ingest indexes (delete + add index) one by one, which can not take advantage of the DDL concurrent adding indexes feature.

What changed and how does it work?

Create more sessions to repair ingest indexes concurrently.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-tests-checked release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed do-not-merge/needs-tests-checked labels Jan 23, 2025
Copy link

tiprow bot commented Jan 23, 2025

Hi @Leavrth. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

codecov bot commented Jan 23, 2025

Codecov Report

Attention: Patch coverage is 54.16667% with 44 lines in your changes missing coverage. Please review.

Project coverage is 74.7315%. Comparing base (9c37399) to head (c54028b).
Report is 118 commits behind head on master.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #59159        +/-   ##
================================================
+ Coverage   73.0489%   74.7315%   +1.6826%     
================================================
  Files          1684       1706        +22     
  Lines        466386     484027     +17641     
================================================
+ Hits         340690     361721     +21031     
+ Misses       104751     100013      -4738     
- Partials      20945      22293      +1348     
Flag Coverage Δ
integration 46.1407% <47.9166%> (?)
unit 72.4080% <52.0833%> (+0.1662%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.6910% <ø> (ø)
parser ∅ <ø> (∅)
br 60.0599% <54.1666%> (+14.7367%) ⬆️

Signed-off-by: Jianjun Liao <[email protected]>
@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Feb 6, 2025
Signed-off-by: Jianjun Liao <[email protected]>
@ti-chi-bot ti-chi-bot bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 7, 2025
w := console.StartProgressBar(progressTitle, glue.OnlyOneTask)
defer w.Close()
sessionCount := defaultRepairIndexSessionCount
unsafeSessions, err := createSessions(ctx, g, rc.dom.Store(), sessionCount)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

...Actually this is safe if you only use these sessions in the function and not share them

Copy link
Contributor

@3pointer 3pointer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rest LGTM

Copy link

ti-chi-bot bot commented Feb 11, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 3pointer, BornChanger

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Feb 11, 2025
Copy link

ti-chi-bot bot commented Feb 11, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-02-06 06:18:30.77736991 +0000 UTC m=+338982.309781906: ☑️ agreed by BornChanger.
  • 2025-02-11 06:31:52.047812447 +0000 UTC m=+338154.444034507: ☑️ agreed by 3pointer.

@Leavrth
Copy link
Contributor Author

Leavrth commented Feb 11, 2025

/hold

@ti-chi-bot ti-chi-bot bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 11, 2025
Signed-off-by: Jianjun Liao <[email protected]>
@Leavrth
Copy link
Contributor Author

Leavrth commented Feb 11, 2025

/unhold

@ti-chi-bot ti-chi-bot bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 11, 2025
@Leavrth
Copy link
Contributor Author

Leavrth commented Feb 11, 2025

/ok-to-test

@ti-chi-bot ti-chi-bot bot added the ok-to-test Indicates a PR is ready to be tested. label Feb 11, 2025
Signed-off-by: Jianjun Liao <[email protected]>
@ti-chi-bot ti-chi-bot bot merged commit e7d7cdc into pingcap:master Feb 11, 2025
25 checks passed
@BornChanger BornChanger added the needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. label Feb 19, 2025
ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Feb 19, 2025
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.5: #59639.
But this PR has conflicts, please resolve them!

michaelmdeng pushed a commit to michaelmdeng/tidb that referenced this pull request Feb 26, 2025
michaelmdeng pushed a commit to michaelmdeng/tidb that referenced this pull request Feb 26, 2025
michaelmdeng pushed a commit to michaelmdeng/tidb that referenced this pull request Feb 26, 2025
zeminzhou pushed a commit to zeminzhou/tidb that referenced this pull request May 6, 2025
ti-chi-bot bot pushed a commit that referenced this pull request Jul 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

repair ingest indexes concurrently during log restore
4 participants