-
Notifications
You must be signed in to change notification settings - Fork 6k
planner: add tolerance for row count floating point comparison #59241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hi @terry1purcell. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #59241 +/- ##
================================================
+ Coverage 73.0608% 73.5983% +0.5375%
================================================
Files 1689 1689
Lines 467012 467562 +550
================================================
+ Hits 341203 344118 +2915
+ Misses 104839 102532 -2307
+ Partials 20970 20912 -58
Flags with carried forward coverage won't be shown. Click here to find out more.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hawkingrei, winoros The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
/cherry-pick release-8.5 |
Signed-off-by: ti-chi-bot <[email protected]>
@terry1purcell: new pull request created to branch In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
/cherry-pick release-8.1 |
Signed-off-by: ti-chi-bot <[email protected]>
@terry1purcell: new pull request created to branch In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
What problem does this PR solve?
Issue Number: close #59133
Problem Summary:
What changed and how does it work?
Due to precision errors in floating point, a small tolerance is needed to ensure that an unnecessary adjustments are not made for cardinality estimation. An arbitrary value of 0.00001 is used as the tolerance.
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.