-
Notifications
You must be signed in to change notification settings - Fork 6k
executor: fix prepared protocol charset (#58872) #59263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
executor: fix prepared protocol charset (#58872) #59263
Conversation
Signed-off-by: ti-chi-bot <[email protected]>
Signed-off-by: xhe <[email protected]>
Signed-off-by: xhe <[email protected]>
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Defined2014, tangenta The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release-7.1 #59263 +/- ##
================================================
Coverage ? 73.4565%
================================================
Files ? 1213
Lines ? 382139
Branches ? 0
================================================
Hits ? 280706
Misses ? 83489
Partials ? 17944 |
This is an automated cherry-pick of #58872
What problem does this PR solve?
Issue Number: close #58870
Problem Summary:
When it is text-prepare, SQL will be parsed twice. The first time, it is already transformed to utf8 due to
charset_client
. Thus when it comes to executor, only the other two parameters need to set.But if it is coming from prepare protocol, SQL have not been parsed before. We also need to set
charset_client
to transform it to utf8.Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.