Skip to content

Conversation

D3Hunter
Copy link
Contributor

@D3Hunter D3Hunter commented Feb 6, 2025

What problem does this PR solve?

Issue Number: close #59267

Problem Summary:

What changed and how does it work?

  • also consider ctx.Done when sending events

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Feb 6, 2025
Copy link

tiprow bot commented Feb 6, 2025

Hi @D3Hunter. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

go.sum Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why this change?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure why, my local make lint; make bazel_prepare change it automatically. reverted

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Feb 6, 2025
Copy link

codecov bot commented Feb 6, 2025

Codecov Report

Attention: Patch coverage is 50.00000% with 5 lines in your changes missing coverage. Please review.

Project coverage is 74.8358%. Comparing base (fc8bdb5) to head (b24b16e).
Report is 3 commits behind head on master.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #59271        +/-   ##
================================================
+ Coverage   73.0496%   74.8358%   +1.7861%     
================================================
  Files          1689       1735        +46     
  Lines        466978     475669      +8691     
================================================
+ Hits         341126     355971     +14845     
+ Misses       104890      97260      -7630     
- Partials      20962      22438      +1476     
Flag Coverage Δ
integration 48.7864% <0.0000%> (?)
unit 72.2581% <50.0000%> (+0.0263%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.6910% <ø> (ø)
parser ∅ <ø> (∅)
br 60.3251% <ø> (+14.8993%) ⬆️

@ti-chi-bot ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Feb 6, 2025
Copy link

ti-chi-bot bot commented Feb 6, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tangenta, wjhuang2016

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Feb 6, 2025
Copy link

ti-chi-bot bot commented Feb 6, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-02-06 08:05:40.600356414 +0000 UTC m=+345412.132768412: ☑️ agreed by wjhuang2016.
  • 2025-02-06 09:40:03.049565081 +0000 UTC m=+351074.581977064: ☑️ agreed by tangenta.

@ti-chi-bot ti-chi-bot bot merged commit 444c38f into pingcap:master Feb 6, 2025
27 checks passed
@D3Hunter D3Hunter deleted the fix-alter-block branch February 6, 2025 10:00
zeminzhou pushed a commit to zeminzhou/tidb that referenced this pull request May 6, 2025
@joechenrh
Copy link
Contributor

/cherry-pick release-8.5

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Jun 23, 2025
@ti-chi-bot
Copy link
Member

@joechenrh: new pull request created to branch release-8.5: #61927.
But this PR has conflicts, please resolve them!

In response to this:

/cherry-pick release-8.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

reduce add-index worker count might stuck forever if add-index finish right before alter ddl job
5 participants