Skip to content

br: refactor test to use wait checkpoint method (#57612) #59284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Feb 11, 2025
Merged

br: refactor test to use wait checkpoint method (#57612) #59284

merged 4 commits into from
Feb 11, 2025

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #57612

What problem does this PR solve?

Issue Number: close #57609

Problem Summary:

What changed and how does it work?

Extract the wait for checkpoint to advance logic in integration test to a method

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. type/cherry-pick-for-release-8.1 This PR is cherry-picked to release-8.1 from a source PR. labels Feb 7, 2025
@ti-chi-bot ti-chi-bot mentioned this pull request Feb 7, 2025
Merged
13 tasks
@ti-chi-bot
Copy link
Member Author

@Tristan1900 This PR has conflicts, I have hold it.
Please resolve them or ask others to resolve them, then comment /unhold to remove the hold label.

@ti-chi-bot ti-chi-bot bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Feb 7, 2025
@Tristan1900
resolve
62ce980 
Signed-off-by: Wenqi Mou <[email protected]>
@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Feb 7, 2025
@Tristan1900
one more
f9f2d19 
Signed-off-by: Wenqi Mou <[email protected]>
@codecov Codecov
Copy link

codecov bot commented Feb 7, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (release-8.1@278a67c). Learn more about missing BASE report.

Additional details and impacted files 
@@               Coverage Diff                @@
##             release-8.1     #59284   +/-   ##
================================================
  Coverage               ?   71.2842%           
================================================
  Files                  ?       1468           
  Lines                  ?     424471           
  Branches               ?          0           
================================================
  Hits                   ?     302581           
  Misses                 ?     101387           
  Partials               ?      20503
Flag Coverage Δ
unit 71.2842% <100.0000%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.9656% <0.0000%> (?)
parser ∅ <0.0000%> (?)
br 41.4506% <0.0000%> (?)

@ti-chi-bot ti-chi-bot bot added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Feb 7, 2025
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Feb 7, 2025

@RidRisR: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@Tristan1900
piggyback
76e32db 
Signed-off-by: Wenqi Mou <[email protected]>
Tristan1900
Tristan1900 reviewed Feb 7, 2025
View reviewed changes
br/pkg/utils/backoff.go
@@ -295,7 +295,7 @@ func NewRawClientBackoffStrategy() Backoffer {
return &RawClientBackoffStrategy{
Attempts: rawClientMaxAttempts,
BaseBackoff: rawClientDelayTime,
MaxBackoff: rawClientMaxAttempts,
MaxBackoff: rawClientMaxDelayTime,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

piggyback on this PR, that was a typo from previous cp

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Feb 8, 2025
@BornChanger
Copy link
Contributor

/retest

@Tristan1900
Copy link
Contributor

/unhold

@ti-chi-bot ti-chi-bot bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 10, 2025
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Feb 11, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 3pointer, Leavrth, RidRisR

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Feb 11, 2025
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Feb 11, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-02-08 01:52:56.21770711 +0000 UTC m=+62218.613929174: ☑️ agreed by Leavrth.
  • 2025-02-11 23:13:16.215465629 +0000 UTC m=+398238.611687858: ☑️ agreed by 3pointer.

@ti-chi-bot ti-chi-bot bot merged commit 18e2ca6 into pingcap:release-8.1 Feb 11, 2025
22 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@3pointer 3pointer 3pointer approved these changes

@Leavrth Leavrth Leavrth approved these changes

+2 more reviewers

@Tristan1900 Tristan1900 Tristan1900 left review comments

@RidRisR RidRisR RidRisR approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@Tristan1900 Tristan1900

Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-8.1 This PR is cherry-picked to release-8.1 from a source PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ti-chi-bot @BornChanger @Tristan1900 @3pointer @Leavrth @RidRisR