Skip to content

Conversation

rleungx
Copy link
Member

@rleungx rleungx commented Feb 7, 2025

What problem does this PR solve?

Issue Number: ref #58780

Problem Summary:

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Signed-off-by: Ryan Leung <[email protected]>
@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue do-not-merge/needs-tests-checked release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed do-not-merge/needs-tests-checked do-not-merge/needs-linked-issue labels Feb 7, 2025
@rleungx
Copy link
Member Author

rleungx commented Feb 7, 2025

/retest

Copy link

codecov bot commented Feb 7, 2025

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 73.5164%. Comparing base (629a8ec) to head (bb115e1).
Report is 3 commits behind head on master.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #59313        +/-   ##
================================================
+ Coverage   73.0921%   73.5164%   +0.4242%     
================================================
  Files          1689       1689                
  Lines        466998     467041        +43     
================================================
+ Hits         341339     343352      +2013     
+ Misses       104686     102714      -1972     
- Partials      20973      20975         +2     
Flag Coverage Δ
integration 42.8165% <0.0000%> (?)
unit 72.2853% <0.0000%> (+0.0030%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.6910% <ø> (ø)
parser ∅ <ø> (∅)
br 45.4688% <ø> (+0.0114%) ⬆️

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Feb 7, 2025
Copy link

ti-chi-bot bot commented Feb 7, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hawkingrei, JmPotato

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added approved lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Feb 7, 2025
Copy link

ti-chi-bot bot commented Feb 7, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-02-07 07:51:37.018821393 +0000 UTC m=+430968.551233390: ☑️ agreed by JmPotato.
  • 2025-02-07 08:31:28.90069619 +0000 UTC m=+433360.433108183: ☑️ agreed by hawkingrei.

@ti-chi-bot ti-chi-bot bot merged commit c60c841 into pingcap:master Feb 7, 2025
24 checks passed
@rleungx rleungx deleted the update-pd-client-ac4e640fac03 branch February 8, 2025 01:42
zeminzhou pushed a commit to zeminzhou/tidb that referenced this pull request May 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants