-
Notifications
You must be signed in to change notification settings - Fork 6k
expression: fix tikv crash when bool like cast(bit as char)
(#57484)
#59314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
expression: fix tikv crash when bool like cast(bit as char)
(#57484)
#59314
Conversation
Signed-off-by: ti-chi-bot <[email protected]>
f73e3cc
to
49933d8
Compare
@lcwangchao This PR has conflicts, I have hold it. |
/retest |
1 similar comment
/retest |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-7.5 #59314 +/- ##
================================================
Coverage ? 72.1422%
================================================
Files ? 1417
Lines ? 413457
Branches ? 0
================================================
Hits ? 298277
Misses ? 95168
Partials ? 20012
Flags with carried forward coverage won't be shown. Click here to find out more.
|
/unhold |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
[LGTM Timeline notifier]Timeline:
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lcwangchao, qw4990, windtalker The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This is an automated cherry-pick of #57484
What problem does this PR solve?
Issue Number: close #56494
What changed and how does it work?
When casting the bit type to a non binary string, this PR first convert bits to binary string first. This can ensure
HandleBinaryLiteral
can be used in the following code and convert binary to the specified collation with right behavior.Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.