ddl notifier: use pessimistic txn and fix updating memory state too early (#59157) #59330
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ti-chi-bot <[email protected]>
ti-chi-bot
added
do-not-merge/hold
|
@lance6716 This PR has conflicts, I have hold it. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-8.5 #59330 +/- ##
================================================
Coverage ? 57.3967%
================================================
Files ? 1769
Lines ? 627591
Branches ? 0
================================================
Hits ? 360217
Misses ? 242886
Partials ? 24488
Flags with carried forward coverage won't be shown. Click here to find out more.
|
0xPoe
approved these changes
Feb 10, 2025
| @@ -969,6 +969,7 @@ Limit_7 256.00 <actRows> root NULL NULL offset:0, count:100000 <memory> <disk> | |||
| └─TableFullScan_9 256.00 <actRows> cop[tikv] table:pt NULL keep order:false <memory> <disk> | |||
| explain analyze select * from pt where val = 125 limit 100; # expected distsql concurrency 15 | |||
| id estRows actRows task access object execution info operator info memory disk | |||
| <<<<<<< HEAD | |||
Signed-off-by: lance6716 <[email protected]>
ti-chi-bot
bot
added
cherry-pick-approved
Signed-off-by: lance6716 <[email protected]>
Signed-off-by: lance6716 <[email protected]>
lance6716
approved these changes
Feb 10, 2025
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lance6716, Rustin170506 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ti-chi-bot
bot
added
approved
lgtm
and removed
needs-1-more-lgtm
[LGTM Timeline notifier]Timeline:
|
Signed-off-by: lance6716 <[email protected]>
Signed-off-by: lance6716 <[email protected]>
|
/unhold |
ti-chi-bot
bot
removed
the
do-not-merge/hold
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated cherry-pick of #59157
What problem does this PR solve?
Issue Number: close #59055
Problem Summary:
What changed and how does it work?
in pessimistic txn, errors can be found earlier, such as when execute the SQL. So handler can see the error and process it. Otherwise the error is reported when COMMIT, and in current handler interface it can't be proccessed
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.