Skip to content

Conversation

djshow832
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #59336

Problem Summary:
Some users only want TiProxy to replay traffic, which needs session states but not session tokens.
However, show session_states reports errors when the signing cert is unavailable. Installing signing certs requires TiDB to restart, but users don't want that.

What changed and how does it work?

Return NULL in the token column if the signing cert is unavailable.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added do-not-merge/invalid-title release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 8, 2025
Copy link

tiprow bot commented Feb 8, 2025

Hi @djshow832. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@djshow832 djshow832 changed the title Support showing session_states when signing cert is unavailable executor: support showing session_states when signing cert is unavailable Feb 8, 2025
Copy link

codecov bot commented Feb 8, 2025

Codecov Report

Attention: Patch coverage is 60.00000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 73.4674%. Comparing base (a69f863) to head (4eddad7).
Report is 48 commits behind head on master.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #59337        +/-   ##
================================================
+ Coverage   73.1091%   73.4674%   +0.3582%     
================================================
  Files          1689       1690         +1     
  Lines        466728     472948      +6220     
================================================
+ Hits         341221     347463      +6242     
+ Misses       104552     104318       -234     
- Partials      20955      21167       +212     
Flag Coverage Δ
integration 42.9417% <0.0000%> (?)
unit 72.2550% <60.0000%> (-0.0442%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.6910% <ø> (ø)
parser ∅ <ø> (∅)
br 44.6202% <ø> (-0.6829%) ⬇️

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Feb 8, 2025
Copy link
Member

@bb7133 bb7133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

ti-chi-bot bot commented Feb 9, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bb7133, xhebox

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Feb 9, 2025
Copy link

ti-chi-bot bot commented Feb 9, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-02-08 23:54:10.284601952 +0000 UTC m=+141492.680824009: ☑️ agreed by xhebox.
  • 2025-02-09 02:33:07.973655089 +0000 UTC m=+151030.369877151: ☑️ agreed by bb7133.

@ti-chi-bot ti-chi-bot bot merged commit 3e01fe7 into pingcap:master Feb 9, 2025
24 checks passed
@djshow832 djshow832 deleted the session_token branch February 9, 2025 08:22
zeminzhou pushed a commit to zeminzhou/tidb that referenced this pull request May 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support showing session_states when signing cert is unavailable
3 participants