-
Notifications
You must be signed in to change notification settings - Fork 6k
executor: support showing session_states when signing cert is unavailable #59337
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hi @djshow832. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #59337 +/- ##
================================================
+ Coverage 73.1091% 73.4674% +0.3582%
================================================
Files 1689 1690 +1
Lines 466728 472948 +6220
================================================
+ Hits 341221 347463 +6242
+ Misses 104552 104318 -234
- Partials 20955 21167 +212
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bb7133, xhebox The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What problem does this PR solve?
Issue Number: close #59336
Problem Summary:
Some users only want TiProxy to replay traffic, which needs session states but not session tokens.
However,
show session_states
reports errors when the signing cert is unavailable. Installing signing certs requires TiDB to restart, but users don't want that.What changed and how does it work?
Return NULL in the token column if the signing cert is unavailable.
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.