-
Notifications
You must be signed in to change notification settings - Fork 6k
ttl: fix the issue that the TTL jobs are skipped or handled multiple times in one iteration #59348
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…ated multiple times Signed-off-by: Yang Keao <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #59348 +/- ##
================================================
+ Coverage 73.0649% 73.5381% +0.4731%
================================================
Files 1690 1690
Lines 467071 467166 +95
================================================
+ Hits 341265 343545 +2280
+ Misses 104848 102719 -2129
+ Partials 20958 20902 -56
Flags with carried forward coverage won't be shown. Click here to find out more.
|
NO. @lcwangchao told me it'll also flush all statistic data of a TTL job if a job is finished multiple times 🤦 . |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Defined2014, lcwangchao The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
Signed-off-by: ti-chi-bot <[email protected]>
In response to a cherrypick label: new pull request created to branch |
Signed-off-by: ti-chi-bot <[email protected]>
In response to a cherrypick label: new pull request created to branch |
In response to a cherrypick label: new pull request created to branch |
Signed-off-by: ti-chi-bot <[email protected]>
Signed-off-by: ti-chi-bot <[email protected]>
In response to a cherrypick label: new pull request created to branch |
…times in one iteration (pingcap#59348) close pingcap#59347
What problem does this PR solve?
Issue Number: close #59347
Problem Summary:
Some of the TTL jobs are skipped for handled multiple times in one iteration. It caused the following effect:
CheckNotOwnedJob
,checkFinishedJob
,rescheduleJobs
to handle all existing jobs.I think it's a minor issue as both of them don't block the TTL.
What changed and how does it work?
Iterate the jobs in the reverse order.
Check List
Tests
Release note