-
Notifications
You must be signed in to change notification settings - Fork 6k
expression: support timestampdiff
pushdown to tikv
#59366
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: gengliqi <[email protected]>
Hi @gengliqi. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/ok-to-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #59366 +/- ##
================================================
+ Coverage 73.0210% 73.5171% +0.4960%
================================================
Files 1690 1690
Lines 467068 467359 +291
================================================
+ Hits 341058 343589 +2531
+ Misses 105020 102790 -2230
+ Partials 20990 20980 -10
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Signed-off-by: gengliqi <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: windtalker, wshwsh12, yibin87 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: gengliqi <[email protected]>
What problem does this PR solve?
Issue Number: close #59365
Problem Summary:
What changed and how does it work?
expression: support
timestampdiff
pushdown to tikvCheck List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.