Skip to content

Conversation

lance6716
Copy link
Contributor

@lance6716 lance6716 commented Feb 13, 2025

What problem does this PR solve?

Issue Number: close #59501

Problem Summary:

What changed and how does it work?

seems when domain is closing, DDL notifier may not exit in time. So we tolerate some error

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-triage-completed release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 13, 2025
@lance6716 lance6716 requested a review from 0xPoe February 13, 2025 04:44
Copy link

tiprow bot commented Feb 13, 2025

Hi @lance6716. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

codecov bot commented Feb 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.9321%. Comparing base (b7e9769) to head (9b3bff4).
Report is 3 commits behind head on master.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #59503        +/-   ##
================================================
+ Coverage   72.9819%   74.9321%   +1.9502%     
================================================
  Files          1693       1739        +46     
  Lines        467972     477353      +9381     
================================================
+ Hits         341535     357691     +16156     
+ Misses       105410      97159      -8251     
- Partials      21027      22503      +1476     
Flag Coverage Δ
integration 48.8520% <50.0000%> (?)
unit 72.2202% <50.0000%> (+0.0619%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.6910% <ø> (ø)
parser ∅ <ø> (∅)
br 61.6906% <ø> (+16.2222%) ⬆️

Copy link
Member

@0xPoe 0xPoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Signed-off-by: lance6716 <[email protected]>
@ti-chi-bot ti-chi-bot bot added the sig/planner SIG: Planner label Feb 13, 2025
Copy link
Member

@0xPoe 0xPoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! :shipit:

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Feb 13, 2025
@lance6716
Copy link
Contributor Author

/retest

Copy link

tiprow bot commented Feb 13, 2025

@lance6716: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

ti-chi-bot bot commented Feb 13, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Rustin170506, wjhuang2016

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added approved lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Feb 13, 2025
Copy link

ti-chi-bot bot commented Feb 13, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-02-13 06:17:22.64572134 +0000 UTC m=+510085.041943395: ☑️ agreed by Rustin170506.
  • 2025-02-13 07:47:40.325777469 +0000 UTC m=+515502.721999530: ☑️ agreed by wjhuang2016.

@ti-chi-bot ti-chi-bot bot merged commit 6e62f56 into pingcap:master Feb 13, 2025
25 of 27 checks passed
zeminzhou pushed a commit to zeminzhou/tidb that referenced this pull request May 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

flaky test on DDLNotifier
3 participants