-
Notifications
You must be signed in to change notification settings - Fork 6k
bootstrap: add cluster_id
to the mysql.tidb
table
#59511
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
/cc @benmeadowcroft |
@YangKeao: GitHub didn't allow me to request PR reviews from the following users: BenMeadowcroft. Note that only pingcap members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #59511 +/- ##
================================================
+ Coverage 73.0599% 74.8387% +1.7788%
================================================
Files 1690 1740 +50
Lines 467367 479651 +12284
================================================
+ Hits 341458 358965 +17507
+ Misses 104902 98239 -6663
- Partials 21007 22447 +1440
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix the UT
[LGTM Timeline notifier]Timeline:
|
82cae88
to
c76256f
Compare
Signed-off-by: Yang Keao <[email protected]>
c76256f
to
43a9ed8
Compare
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Defined2014, lance6716, Leavrth, yudongusa The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What problem does this PR solve?
Issue Number: close #59476
Problem Summary:
We need a mechanism to detect whether two TiDB servers are in the same tidb cluster. Adding the
cluster_id
to themysql.tidb
table is the most sutiable way. I've also considered other options in #59476 .What changed and how does it work?
Add the
cluster_id
row to themysql.tidb
table.Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.