ddl: let partition table pre split index regions #59547
Conversation
ti-chi-bot
bot
added
release-note-none
|
Hi @Defined2014. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #59547 +/- ##
================================================
+ Coverage 73.0327% 74.8273% +1.7945%
================================================
Files 1693 1741 +48
Lines 468064 477041 +8977
================================================
+ Hits 341840 356957 +15117
+ Misses 105205 97592 -7613
- Partials 21019 22492 +1473
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
/retest |
|
@Defined2014: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/retest |
|
@Defined2014: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/retest |
|
@Defined2014: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
ti-chi-bot
bot
added
needs-1-more-lgtm
| @@ -38,6 +38,8 @@ func splitPartitionTableRegion(ctx sessionctx.Context, store kv.SplittableStore, | |||
| defer cancel() | |||
| ctxWithTimeout = kv.WithInternalSourceType(ctxWithTimeout, kv.InternalTxnDDL) | |||
| if shardingBits(tbInfo) > 0 && tbInfo.PreSplitRegions > 0 { | |||
| scatter, tableID := getScatterConfig(scatterScope, tbInfo.ID) | |||
| regionIDs = append(regionIDs, splitIndexRegion(store, tbInfo, scatter, tableID)...) | |||
There was a problem hiding this comment.
Is it for the global index？ Could we add a comment for it？
Besides, do we need to update the capacity for regionIDs?
| require.Regexp(t, fmt.Sprintf("t_%d_r_.*", tbl.Meta().ID+1), rows[3][1]) | ||
| require.Regexp(t, fmt.Sprintf("t_%d_r_.*", tbl.Meta().ID+1), rows[4][1]) | ||
| require.Equal(t, fmt.Sprintf("t_%d_", tbl.Meta().ID+1), rows[5][1]) // index `idx0` | ||
| require.Equal(t, fmt.Sprintf("t_%d_i_3_", tbl.Meta().ID+1), rows[6][1]) // index `idx1` |
There was a problem hiding this comment.
Should we consider adding a test case with both a global index and a normal index?
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tangenta, zimulala The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What problem does this PR solve?
Issue Number: close #59530
Problem Summary:
What changed and how does it work?
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.