Skip to content

Conversation

RidRisR
Copy link
Contributor

@RidRisR RidRisR commented Feb 18, 2025

What problem does this PR solve?

Issue Number: close #59604

Problem Summary:

The CI test idc-jenkins-ci-tidb/check_dev_2 may fail when checking safepoint.
This is because there is gc safepoint registered by other concurrent test.

What changed and how does it work?

Only check the gc safepoint registered by current test.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue do-not-merge/needs-tests-checked release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 18, 2025
Copy link

tiprow bot commented Feb 18, 2025

Hi @RidRisR. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

codecov bot commented Feb 18, 2025

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 74.6523%. Comparing base (8059751) to head (4474984).
Report is 9 commits behind head on master.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #59605        +/-   ##
================================================
+ Coverage   73.0128%   74.6523%   +1.6395%     
================================================
  Files          1694       1710        +16     
  Lines        468330     471227      +2897     
================================================
+ Hits         341941     351782      +9841     
+ Misses       105359      97588      -7771     
- Partials      21030      21857       +827     
Flag Coverage Δ
integration 46.1098% <0.0000%> (?)
unit 72.2244% <0.0000%> (+0.0093%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.6910% <ø> (ø)
parser ∅ <ø> (∅)
br 61.5143% <0.0000%> (+16.2916%) ⬆️

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Feb 18, 2025
Copy link

ti-chi-bot bot commented Feb 18, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BornChanger, YuJuncen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Feb 18, 2025
Copy link

ti-chi-bot bot commented Feb 18, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-02-18 10:07:44.732916665 +0000 UTC m=+955907.129138740: ☑️ agreed by YuJuncen.
  • 2025-02-18 10:20:56.619916136 +0000 UTC m=+956699.016138195: ☑️ agreed by BornChanger.

@ti-chi-bot ti-chi-bot bot merged commit 5a166e1 into pingcap:master Feb 18, 2025
23 checks passed
@RidRisR RidRisR deleted the gc-check branch February 18, 2025 15:25
zeminzhou pushed a commit to zeminzhou/tidb that referenced this pull request May 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

br: CI fail due to unexpected gc safepoint
3 participants