-
Notifications
You must be signed in to change notification settings - Fork 6k
ddl: Add checks for all partitioning columns during EXCHANGE PARTITION for RANGE COLUMNS #59612
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ddl: Add checks for all partitioning columns during EXCHANGE PARTITION for RANGE COLUMNS #59612
Conversation
Hi @mjonss. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #59612 +/- ##
================================================
+ Coverage 72.9712% 74.9588% +1.9876%
================================================
Files 1699 1745 +46
Lines 469334 478593 +9259
================================================
+ Hits 342479 358748 +16269
+ Misses 105754 97333 -8421
- Partials 21101 22512 +1411
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.
Files not reviewed (1)
- pkg/ddl/tests/partition/BUILD.bazel: Language not supported
Comments suppressed due to low confidence (4)
pkg/ddl/partition.go:4353
- Ensure that the handling of MAXVALUE in the first partition is covered by tests.
// TODO: Handle MAXVALUE in first partition
pkg/ddl/partition.go:4482
- Verify the correctness of the logic for list columns partition and ensure it is covered by tests.
// TODO: Verify if this is correct!!!
pkg/ddl/partition.go:4483
- Ensure that the handling of DEFAULT partition is covered by tests.
// TODO: Handle DEFAULT partition!
pkg/ddl/partition.go:4484
- Verify the usage of paramList with column names and ensure it is covered by tests.
// TODO: use paramList with column names, instead of quoting.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TestMultiSchemaPartitionByGlobalIndex
test failed
/retest |
@mjonss: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/retest |
@mjonss: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Defined2014, tangenta The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
In response to a cherrypick label: new pull request created to branch |
Signed-off-by: ti-chi-bot <[email protected]>
In response to a cherrypick label: new pull request created to branch |
…N for RANGE COLUMNS (pingcap#59612) close pingcap#59534
What problem does this PR solve?
Issue Number: close #59534
Problem Summary:
The validation for RANGE COLUMNS partitioned tables in EXCHANGE PARTITION only checked the first column.
What changed and how does it work?
Extended the implementation for multiple columns and added tests to verify the validation.
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.