Skip to content

parser: supports process Multiple COLLATE clauses errors | tidb-test=pr/2484 #59642

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Feb 20, 2025
Merged

parser: supports process Multiple COLLATE clauses errors | tidb-test=pr/2484 #59642

merged 5 commits into from
Feb 20, 2025

Conversation

Defined2014
Copy link
Contributor

@Defined2014 Defined2014 commented Feb 19, 2025 •
edited
Loading

What problem does this PR solve?

Issue Number: close #35195

Problem Summary:

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-triage-completed release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 19, 2025
@tiprow tiprow
Copy link

tiprow bot commented Feb 19, 2025

Hi @Defined2014. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed do-not-merge/needs-triage-completed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 19, 2025
@Defined2014 Defined2014 added the compatibility-breaker Violation of forwards/backwards compatibility in a design-time piece. label Feb 19, 2025
@codecov Codecov
Copy link

codecov bot commented Feb 19, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 86.20690% with 4 lines in your changes missing coverage. Please review.

Project coverage is 73.6380%. Comparing base (a9e69d5) to head (d9f6c95).
Report is 15 commits behind head on master.

Additional details and impacted files 
@@               Coverage Diff                @@
##             master     #59642        +/-   ##
================================================
+ Coverage   73.0003%   73.6380%   +0.6376%     
================================================
  Files          1694       1699         +5     
  Lines        468484     471353      +2869     
================================================
+ Hits         341995     347095      +5100     
+ Misses       105454     103297      -2157     
+ Partials      21035      20961        -74
Flag Coverage Δ
integration 42.8999% <ø> (?)
unit 72.4690% <86.2069%> (+0.2735%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.6910% <ø> (ø)
parser ∅ <ø> (∅)
br 44.9307% <ø> (-0.2874%) ⬇️

@Defined2014
Copy link
Contributor Author

/retest

@tiprow tiprow
Copy link

tiprow bot commented Feb 19, 2025

@Defined2014: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

zimulala
zimulala approved these changes Feb 20, 2025
View reviewed changes
Copy link
Contributor

@zimulala zimulala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Feb 20, 2025
@Defined2014 Defined2014 changed the title parser: supports report Multiple COLLATE clauses errors | tidb-test=pr/2484 parser: supports report Multiple COLLATE clauses errors | tidb-test=pr/2484 Feb 20, 2025
@Defined2014 Defined2014 changed the title parser: supports report Multiple COLLATE clauses errors | tidb-test=pr/2484 parser: supports process Multiple COLLATE clauses errors | tidb-test=pr/2484 Feb 20, 2025
@Defined2014 Defined2014 removed the compatibility-breaker Violation of forwards/backwards compatibility in a design-time piece. label Feb 20, 2025
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Feb 20, 2025
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Feb 20, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-02-20 01:59:36.087597131 +0000 UTC m=+1099418.483819193: ☑️ agreed by zimulala.
  • 2025-02-20 06:58:31.608207628 +0000 UTC m=+1117354.004429685: ☑️ agreed by xhebox.

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Feb 20, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: benmeadowcroft, tangenta, xhebox, zimulala

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Feb 20, 2025
@Defined2014
Copy link
Contributor Author

/retest

@tiprow tiprow
Copy link

tiprow bot commented Feb 20, 2025

@Defined2014: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@Defined2014
Copy link
Contributor Author

/retest

@tiprow tiprow
Copy link

tiprow bot commented Feb 20, 2025

@Defined2014: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@Defined2014
Copy link
Contributor Author

/retest

@tiprow tiprow
Copy link

tiprow bot commented Feb 20, 2025

@Defined2014: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot bot merged commit fdf33cf into pingcap:master Feb 20, 2025
24 checks passed
@Defined2014 Defined2014 deleted the fix-35195 branch February 20, 2025 11:34
zeminzhou pushed a commit to zeminzhou/tidb that referenced this pull request May 6, 2025
@Defined2014 @zeminzhou
parser: supports process Multiple COLLATE clauses errors (pingcap#5…
06d6049 
…9642)

close pingcap#35195
budney pushed a commit to budney/tidb that referenced this pull request May 18, 2025
@Defined2014
parser: supports process Multiple COLLATE clauses errors (pingcap#5…
93f904c 
…9642)

close pingcap#35195
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zimulala zimulala zimulala approved these changes

@xhebox xhebox xhebox approved these changes

@tangenta tangenta tangenta approved these changes

@bb7133 bb7133 Awaiting requested review from bb7133

+1 more reviewer

@benmeadowcroft benmeadowcroft benmeadowcroft approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Multiple collations should fail creating table .
5 participants
@Defined2014 @benmeadowcroft @zimulala @xhebox @tangenta