Skip to content

Conversation

winoros
Copy link
Member

@winoros winoros commented Feb 19, 2025

What problem does this PR solve?

Issue Number: close #59274

Problem Summary:

What changed and how does it work?

the mergeBuffer is in reverse order. we need to call slices.Reverse before join it with others.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-triage-completed release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 19, 2025
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Feb 19, 2025
Copy link

codecov bot commented Feb 19, 2025

Codecov Report

Attention: Patch coverage is 72.72727% with 6 lines in your changes missing coverage. Please review.

Project coverage is 73.6109%. Comparing base (9b8296b) to head (61976c8).
Report is 14 commits behind head on master.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #59647        +/-   ##
================================================
+ Coverage   72.9702%   73.6109%   +0.6406%     
================================================
  Files          1694       1729        +35     
  Lines        468610     480408     +11798     
================================================
+ Hits         341946     353633     +11687     
+ Misses       105603     105034       -569     
- Partials      21061      21741       +680     
Flag Coverage Δ
integration 45.8122% <4.5454%> (?)
unit 72.3130% <72.7272%> (+0.1337%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.6910% <ø> (ø)
parser ∅ <ø> (∅)
br 44.9537% <ø> (-0.1500%) ⬇️

Copy link

ti-chi-bot bot commented Feb 19, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AilinKid, hawkingrei

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Feb 19, 2025
Copy link

ti-chi-bot bot commented Feb 19, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-02-19 09:45:49.558243537 +0000 UTC m=+1040991.954465596: ☑️ agreed by AilinKid.
  • 2025-02-19 16:55:30.501761089 +0000 UTC m=+1066772.897983151: ☑️ agreed by hawkingrei.

@hawkingrei
Copy link
Member

/retest

@ti-chi-bot ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 20, 2025
@winoros winoros changed the title statistics: correct the bucket order when merging gloal hist statistics: correct the bucket order when merging global hist Feb 20, 2025
@winoros
Copy link
Member Author

winoros commented Feb 20, 2025

the bench function BenchmarkMergePartitionHist2GlobalHist can test it.

@ti-chi-bot ti-chi-bot bot merged commit 7221354 into pingcap:master Feb 20, 2025
25 checks passed
@winoros winoros deleted the 59274 branch February 21, 2025 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

merge global histogram failed after #52218
3 participants