build(deps): bump github.com/prometheus/client_golang from 1.20.5 to 1.21.0 #59685

dependabot · 2025-02-21T04:21:06Z

Bumps github.com/prometheus/client_golang from 1.20.5 to 1.21.0.

Release notes

Sourced from github.com/prometheus/client_golang's releases.

v1.21.0 / 2025-02-19

⚠️ This release contains potential breaking change if you upgrade github.com/prometheus/common to 0.62+ together with client_golang (and depend on the strict, legacy validation for the label names). New common version changes model.NameValidationScheme global variable, which relaxes the validation of label names and metric name, allowing all UTF-8 characters. Typically, this should not break any user, unless your test or usage expects strict certain names to panic/fail on client_golang metric registration, gathering or scrape. In case of problems change model.NameValidationScheme to old model.LegacyValidation value in your project init function. ⚠️

[BUGFIX] gocollector: Fix help message for runtime/metric metrics. #1583

[BUGFIX] prometheus: Fix Desc.String() method for no labels case. #1687

[PERF] prometheus: Optimize popular prometheus.BuildFQName function; now up to 30% faster. #1665

[PERF] prometheus: Optimize Inc, Add and Observe cumulative metrics; now up to 50% faster under high concurrent contention. #1661

[CHANGE] Upgrade prometheus/common to 0.62.0 which changes model.NameValidationScheme global variable. #1712

[CHANGE] Add support for Go 1.23. #1602

[FEATURE] process_collector: Add support for Darwin systems. #1600 #1616 #1625 #1675 #1715

[FEATURE] api: Add ability to invoke CloseIdleConnections on api.Client using api.Client.(CloseIdler).CloseIdleConnections() casting. #1513

[FEATURE] promhttp: Add promhttp.HandlerOpts.EnableOpenMetricsTextCreatedSamples option to create OpenMetrics _created lines. Not recommended unless you want to use opt-in Created Timestamp feature. Community works on OpenMetrics 2.0 format that should make those lines obsolete (they increase cardinality significantly). #1408

[FEATURE] prometheus: Add NewConstNativeHistogram function. #1654

... (truncated)

Changelog

Sourced from github.com/prometheus/client_golang's changelog.

1.21.0 / 2025-02-17

⚠️ This release contains potential breaking change if you upgrade github.com/prometheus/common to 0.62+ together with client_golang. ⚠️

New common version changes model.NameValidationScheme global variable, which relaxes the validation of label names and metric name, allowing all UTF-8 characters. Typically, this should not break any user, unless your test or usage expects strict certain names to panic/fail on client_golang metric registration, gathering or scrape. In case of problems change model.NameValidationScheme to old model.LegacyValidation value in your project init function.

[BUGFIX] gocollector: Fix help message for runtime/metric metrics. #1583

[BUGFIX] prometheus: Fix Desc.String() method for no labels case. #1687

[ENHANCEMENT] prometheus: Optimize popular prometheus.BuildFQName function; now up to 30% faster. #1665

[ENHANCEMENT] prometheus: Optimize Inc, Add and Observe cumulative metrics; now up to 50% faster under high concurrent contention. #1661

[CHANGE] Upgrade prometheus/common to 0.62.0 which changes model.NameValidationScheme global variable. #1712

[CHANGE] Add support for Go 1.23. #1602

[FEATURE] process_collector: Add support for Darwin systems. #1600 #1616 #1625 #1675 #1715

[FEATURE] api: Add ability to invoke CloseIdleConnections on api.Client using api.Client.(CloseIdler).CloseIdleConnections() casting. #1513

[FEATURE] promhttp: Add promhttp.HandlerOpts.EnableOpenMetricsTextCreatedSamples option to create OpenMetrics _created lines. Not recommended unless you want to use opt-in Created Timestamp feature. Community works on OpenMetrics 2.0 format that should make those lines obsolete (they increase cardinality significantly). #1408

[FEATURE] prometheus: Add NewConstNativeHistogram function. #1654

Commits

eaf03ef Cut 1.21.0 (#1737)
f1f89dc Cut 1.21.0-rc.0 (#1718)
c923f7c Revert "ci: daggerize test and lint pipelines (#1534)" (#1717)
1bcda80 process collector: Fixed pedantic registry failures on darwin with cgo. (#1715)
038b37a tutorials/whatsup: Updated deps (#1716)
56a2431 docs: Add RELEASE.md for the release process (#1690)
cbd9526 Merge pull request #1713 from prometheus/dependabot/go_modules/tutorials/what...
80b5a2a build(deps): bump golang.org/x/net in /tutorials/whatsup
1a822a8 Upgrade to prometheus/common 0.62.0 with breaking change (#1712)
7b39d01 Update common Prometheus files (#1708)
Additional commits viewable in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

@dependabot rebase will rebase this PR
@dependabot recreate will recreate this PR, overwriting any edits that have been made to it
@dependabot merge will merge this PR after your CI passes on it
@dependabot squash and merge will squash and merge this PR after your CI passes on it
@dependabot cancel merge will cancel a previously requested merge and block automerging
@dependabot reopen will reopen this PR if it is closed
@dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
@dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
@dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
@dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
@dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

What problem does this PR solve?

Issue Number: close #xxx

Problem Summary:

What changed and how does it work?

Check List

Tests

Unit test
Integration test
Manual test (add detailed scripts or steps below)
No need to test
- I checked and no code files have been changed.

Side effects

Performance regression: Consumes more CPU
Performance regression: Consumes more Memory
Breaking backward compatibility

Documentation

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

ti-chi-bot · 2025-02-21T04:21:15Z

Hi @dependabot[bot]. Thanks for your PR.

I'm waiting for a pingcap member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

tiprow · 2025-02-21T04:21:41Z

Hi @dependabot[bot]. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

hawkingrei · 2025-02-21T07:44:34Z

/ok-to-test

YangKeao

LGTM

ti-chi-bot · 2025-02-21T08:14:05Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hawkingrei, YangKeao

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [YangKeao,hawkingrei]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

ti-chi-bot · 2025-02-21T08:14:09Z

[LGTM Timeline notifier]

Timeline:

2025-02-21 05:47:36.318912955 +0000 UTC m=+1199498.715135017: ☑️ agreed by hawkingrei.
2025-02-21 08:14:07.786551827 +0000 UTC m=+1208290.182773889: ☑️ agreed by YangKeao.

codecov · 2025-02-21T08:48:30Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.4855%. Comparing base (d93c233) to head (a29d2e6).
Report is 4 commits behind head on master.

Additional details and impacted files

@@               Coverage Diff                @@
##             master     #59685        +/-   ##
================================================
+ Coverage   72.9601%   73.4855%   +0.5254%     
================================================
  Files          1697       1697                
  Lines        468911     470060      +1149     
================================================
+ Hits         342118     345426      +3308     
+ Misses       105730     103617      -2113     
+ Partials      21063      21017        -46

Flag	Coverage Δ
integration	`42.7201% <ø> (?)`
unit	`72.3396% <ø> (+0.1907%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
dumpling	`52.6910% <ø> (ø)`
parser	`∅ <ø> (∅)`
br	`45.1163% <ø> (+0.0169%)`	⬆️

Defined2014 · 2025-02-24T01:54:06Z

/retest

dependabot · 2025-02-24T01:54:45Z

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

hawkingrei · 2025-02-24T05:41:05Z

/retest

Bumps [github.com/prometheus/client_golang](https://github.com/prometheus/client_golang) from 1.20.5 to 1.21.0. - [Release notes](https://github.com/prometheus/client_golang/releases) - [Changelog](https://github.com/prometheus/client_golang/blob/main/CHANGELOG.md) - [Commits](prometheus/client_golang@v1.20.5...v1.21.0) --- updated-dependencies: - dependency-name: github.com/prometheus/client_golang dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>

Signed-off-by: Weizhen Wang <[email protected]>

hawkingrei · 2025-02-24T08:42:08Z

/retest

…20.5 to 1.21.0 (pingcap#59685)" This reverts commit 1af4fbe.

…1.21.0 (pingcap#59685)

dependabot bot added dependencies Pull requests that update a dependency file go Pull requests that update Go code labels Feb 21, 2025

ti-chi-bot bot added do-not-merge/needs-linked-issue do-not-merge/needs-tests-checked do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Feb 21, 2025

ti-chi-bot bot added needs-ok-to-test Indicates a PR created by contributors and need ORG member send '/ok-to-test' to start testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 21, 2025

hawkingrei approved these changes Feb 21, 2025

View reviewed changes

ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Feb 21, 2025

hawkingrei added the skip-issue-check Indicates that a PR no need to check linked issue. label Feb 21, 2025

ti-chi-bot bot removed the do-not-merge/needs-linked-issue label Feb 21, 2025

hawkingrei requested review from Defined2014 and lance6716 February 21, 2025 08:07

YangKeao approved these changes Feb 21, 2025

View reviewed changes

ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Feb 21, 2025

Defined2014 closed this Feb 24, 2025

Defined2014 reopened this Feb 24, 2025

dependabot bot and others added 4 commits February 24, 2025 14:02

update

d4f793f

Signed-off-by: Weizhen Wang <[email protected]>

update

3badf5b

Signed-off-by: Weizhen Wang <[email protected]>

upate

a29d2e6

Signed-off-by: Weizhen Wang <[email protected]>

hawkingrei force-pushed the dependabot/go_modules/github.com/prometheus/client_golang-1.21.0 branch from a5a600e to a29d2e6 Compare February 24, 2025 06:02

ti-chi-bot bot merged commit 1af4fbe into master Feb 24, 2025
24 checks passed

ti-chi-bot bot deleted the dependabot/go_modules/github.com/prometheus/client_golang-1.21.0 branch February 24, 2025 10:35

owlsome2501 mentioned this pull request Feb 26, 2025

There is a 61.3% performance regression in sysbench after PR#59685 #59784

Closed

Defined2014 added a commit to Defined2014/tidb that referenced this pull request Mar 6, 2025

Revert "build(deps): bump github.com/prometheus/client_golang from 1.…

6dac74d

…20.5 to 1.21.0 (pingcap#59685)" This reverts commit 1af4fbe.

zeminzhou pushed a commit to zeminzhou/tidb that referenced this pull request May 6, 2025

build(deps): bump github.com/prometheus/client_golang from 1.20.5 to …

0543a55

…1.21.0 (pingcap#59685)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

build(deps): bump github.com/prometheus/client_golang from 1.20.5 to 1.21.0 #59685

build(deps): bump github.com/prometheus/client_golang from 1.20.5 to 1.21.0 #59685

Uh oh!

dependabot bot commented on behalf of github Feb 21, 2025 •

edited by hawkingrei

Loading

Uh oh!

ti-chi-bot bot commented Feb 21, 2025

Uh oh!

tiprow bot commented Feb 21, 2025

Uh oh!

hawkingrei commented Feb 21, 2025

Uh oh!

YangKeao left a comment

Uh oh!

ti-chi-bot bot commented Feb 21, 2025

Uh oh!

ti-chi-bot bot commented Feb 21, 2025

Uh oh!

codecov bot commented Feb 21, 2025 •

edited

Loading

Uh oh!

Defined2014 commented Feb 24, 2025

Uh oh!

dependabot bot commented on behalf of github Feb 24, 2025

Uh oh!

hawkingrei commented Feb 24, 2025

Uh oh!

hawkingrei commented Feb 24, 2025

Uh oh!

Uh oh!

Uh oh!

build(deps): bump github.com/prometheus/client_golang from 1.20.5 to 1.21.0 #59685

build(deps): bump github.com/prometheus/client_golang from 1.20.5 to 1.21.0 #59685

Uh oh!

Conversation

dependabot bot commented on behalf of github Feb 21, 2025 • edited by hawkingrei Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

v1.21.0 / 2025-02-19

1.21.0 / 2025-02-17

What problem does this PR solve?

What changed and how does it work?

Check List

Release note

Uh oh!

ti-chi-bot bot commented Feb 21, 2025

Uh oh!

tiprow bot commented Feb 21, 2025

Uh oh!

hawkingrei commented Feb 21, 2025

Uh oh!

YangKeao left a comment

Choose a reason for hiding this comment

Uh oh!

ti-chi-bot bot commented Feb 21, 2025

Uh oh!

ti-chi-bot bot commented Feb 21, 2025

[LGTM Timeline notifier]

Uh oh!

codecov bot commented Feb 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Defined2014 commented Feb 24, 2025

Uh oh!

dependabot bot commented on behalf of github Feb 24, 2025

Uh oh!

hawkingrei commented Feb 24, 2025

Uh oh!

hawkingrei commented Feb 24, 2025

Uh oh!

Uh oh!

Uh oh!

dependabot bot commented on behalf of github Feb 21, 2025 •

edited by hawkingrei

Loading

codecov bot commented Feb 21, 2025 •

edited

Loading