json: fix the issue that two arrays are merged but not append in JSON_ARRAY_APPEND
.
#59688
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #59465
Problem Summary:
Previously,
JSON_ARRAY_APPEND('[1]', '$', '[2,3]')
will give[1,2,3]
, which is not expected. It's because in TiDB theJSON_ARRAY_APPEND
shared the same implementation withJSON_MERGE
. To fix this issue, we should wrap the new item with an array when passing it to the merge logic.What changed and how does it work?
Wrap the new item with array before re-using the merge logic.
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.