Skip to content

Conversation

D3Hunter
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #50451

Problem Summary:

What changed and how does it work?

when reading a file range using s3, the pos must be set, as we will use it as the start position when retry

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 21, 2025
Copy link

tiprow bot commented Feb 21, 2025

Hi @D3Hunter. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

codecov bot commented Feb 21, 2025

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 74.8451%. Comparing base (ba94321) to head (faad6bb).
Report is 309 commits behind head on master.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #59694        +/-   ##
================================================
+ Coverage   72.9585%   74.8451%   +1.8866%     
================================================
  Files          1697       1743        +46     
  Lines        468909     477049      +8140     
================================================
+ Hits         342109     357048     +14939     
+ Misses       105741      97531      -8210     
- Partials      21059      22470      +1411     
Flag Coverage Δ
integration 48.6472% <0.0000%> (?)
unit 72.5023% <50.0000%> (+0.0395%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling ∅ <ø> (∅)
parser ∅ <ø> (∅)
br 62.3479% <50.0000%> (+15.8814%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ti-chi-bot ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 21, 2025
@D3Hunter D3Hunter changed the title [wip]objstore: fix read position on retry when reading a file range using s3 objstore: fix read position on retry when reading a file range using s3 Feb 21, 2025
@ti-chi-bot ti-chi-bot bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 21, 2025
@D3Hunter
Copy link
Contributor Author

/retest

Copy link

tiprow bot commented Feb 21, 2025

@D3Hunter: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Feb 21, 2025
Copy link
Collaborator

@Benjamin2037 Benjamin2037 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added approved lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Feb 21, 2025
Copy link

ti-chi-bot bot commented Feb 21, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-02-21 11:21:02.695597478 +0000 UTC m=+9210.648755738: ☑️ agreed by tangenta.
  • 2025-02-21 15:41:09.144053185 +0000 UTC m=+24817.097211450: ☑️ agreed by Benjamin2037.

@D3Hunter
Copy link
Contributor Author

/retest

Copy link

tiprow bot commented Feb 24, 2025

@D3Hunter: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

ti-chi-bot bot commented Feb 24, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Benjamin2037, Leavrth, tangenta

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot merged commit 907eddd into pingcap:master Feb 24, 2025
35 checks passed
@D3Hunter D3Hunter deleted the fix-s3-reader branch February 24, 2025 02:18
@D3Hunter
Copy link
Contributor Author

/cherry-pick release-8.1-20250226-v8.1.2

@ti-chi-bot
Copy link
Member

@D3Hunter: new pull request created to branch release-8.1-20250226-v8.1.2: #59766.

In response to this:

/cherry-pick release-8.1-20250226-v8.1.2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@D3Hunter
Copy link
Contributor Author

D3Hunter commented Mar 1, 2025

/cherry-pick feature/release-8.1-gsort-test

@ti-chi-bot
Copy link
Member

@D3Hunter: new pull request created to branch feature/release-8.1-gsort-test: #59853.

In response to this:

/cherry-pick feature/release-8.1-gsort-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@Benjamin2037 Benjamin2037 added needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. labels Mar 13, 2025
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.5: #60054.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.1: #60055.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request could not be created: failed to create pull request against pingcap/tidb#release-8.5 from head ti-chi-bot:cherry-pick-59694-to-release-8.5: status code 422 not one of [201], body: {"message":"Validation Failed","errors":[{"resource":"PullRequest","code":"custom","message":"No commits between pingcap:release-8.5 and ti-chi-bot:cherry-pick-59694-to-release-8.5"}],"documentation_url":"https://docs.github.com/rest/pulls/pulls#create-a-pull-request","status":"422"}

zeminzhou pushed a commit to zeminzhou/tidb that referenced this pull request May 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

import into failed when inject global sort dir network delay 50ms with error “read xxx bytes from external storage, exceed max limit 1073741824”
5 participants