Skip to content

br: fix no-schema conflict with duplicated table check #59695

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 24, 2025
Merged

br: fix no-schema conflict with duplicated table check #59695

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions br/tests/br_db_skip/run.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ run_sql "CREATE DATABASE $DB;"
# restore db with skip-create-sql must failed
echo "restore start but must failed"
fail=false
run_br restore db --db $DB -s "local://$TEST_DIR/$DB" --pd $PD_ADDR --no-schema=true || fail=true
run_br restore db --db $DB -s "local://$TEST_DIR/$DB" --pd $PD_ADDR --no-schema=true --check-requirements=false || fail=true
if $fail; then
# Error: [schema:1146]Table 'br_db_skip.usertable1' doesn't exist
echo "TEST: [$TEST_NAME] restore $DB with no-schema must failed"
Expand All @@ -56,7 +56,7 @@ run_sql "CREATE TABLE $DB.usertable1 ( \

echo "restore start must succeed"
fail=false
run_br restore db --db $DB -s "local://$TEST_DIR/$DB" --pd $PD_ADDR --no-schema=true || fail=true
run_br restore db --db $DB -s "local://$TEST_DIR/$DB" --pd $PD_ADDR --no-schema=true --check-requirements=false || fail=true
if $fail; then
echo "TEST: [$TEST_NAME] restore $DB with no-schema failed"
exit 1
Expand Down