unistore: Added error if row is too long to be locked

[mjonss]

What problem does this PR solve?

Issue Number: close #59651

Problem Summary:
The Unistore cannot handle a row is larger than the lockstore arena blocksize.

What changed and how does it work?

Added an error when trying to lock a row that is too big.

Check List

Tests

• Unit test
• Integration test
• Manual test (add detailed scripts or steps below)
• No need to test

  • I checked and no code files have been changed.

Side effects

• Performance regression: Consumes more CPU
• Performance regression: Consumes more Memory
• Breaking backward compatibility

Documentation

• Affects user behaviors
• Contains syntax changes
• Contains variable changes
• Contains experimental features
• Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

Return error if a row is larger than the unistore lock blocksize instead of panic: runtime error: index out of range [-1]

[tiprow]

Hi @mjonss. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.3022%. Comparing base (811be5a) to head (8a4f9c8).
Report is 20 commits behind head on master.

Additional details and impacted files

@@               Coverage Diff                @@
##             master     #59699        +/-   ##
================================================
+ Coverage   72.9648%   73.3022%   +0.3373%     
================================================
  Files          1695       1698         +3     
  Lines        468793     472399      +3606     
================================================
+ Hits         342054     346279      +4225     
+ Misses       105675     105026       -649     
- Partials      21064      21094        +30     

Flag	Coverage Δ
integration	42.7876% <50.0000%> (?)
unit	72.1795% <100.0000%> (+0.0102%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
dumpling	52.6910% <ø> (ø)
parser	∅ <ø> (∅)
br	45.0125% <ø> (-0.0736%)	⬇️

[dveeden]

Another way of doing this would be to reduce the tidb_txn_entry_size_limit on startup if unistore is used. However I think doing this on write as it is done now is easier for people to understand.

Maybe adding a warning on startup would be nice, but I don't think that's needed either.

I think it is clear enough to the user that this is a unistore limitation, but we could explicitly add that to the message as well, just in case it wasn't clear enough.

[dveeden]

/hold

[dveeden]

Approved, but please add the comment as suggested by @Defined2014

[ti-chi-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Defined2014, dveeden

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [Defined2014,dveeden]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[ti-chi-bot]

[LGTM Timeline notifier]

Timeline:

• 2025-02-24 08:16:12.502734704 +0000 UTC m=+257320.455892970: ☑️ agreed by Defined2014.
• 2025-02-24 08:51:58.380024443 +0000 UTC m=+259466.333182708: ☑️ agreed by dveeden.

[dveeden]

/check-issue-triage-complete

[Defined2014]

/retest

[tiprow]

@Defined2014: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[Defined2014]

/unhold