-
Notifications
You must be signed in to change notification settings - Fork 6k
br: fix pre allocate id exceeds bound #59719
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Jianjun Liao <[email protected]>
Hi @Leavrth. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #59719 +/- ##
================================================
+ Coverage 72.9471% 74.5352% +1.5881%
================================================
Files 1697 1713 +16
Lines 468911 470125 +1214
================================================
+ Hits 342057 350409 +8352
+ Misses 105773 97940 -7833
- Partials 21081 21776 +695
Flags with carried forward coverage won't be shown. Click here to find out more.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Tristan1900, YuJuncen The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
/hold holding to wait for resolving CI errors |
Signed-off-by: Jianjun Liao <[email protected]>
/unhold |
/ok-to-test |
Signed-off-by: Jianjun Liao <[email protected]>
Signed-off-by: ti-chi-bot <[email protected]>
In response to a cherrypick label: new pull request created to branch |
In response to a cherrypick label: new pull request created to branch |
Signed-off-by: ti-chi-bot <[email protected]>
In response to a cherrypick label: new pull request created to branch |
What problem does this PR solve?
Issue Number: close #59718
Problem Summary:
BR snapshot restore reuses the last global ID when pre-allocates table IDs
What changed and how does it work?
pre-allocate from
last global ID + 1
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.