Skip to content

Conversation

Leavrth
Copy link
Contributor

@Leavrth Leavrth commented Feb 24, 2025

What problem does this PR solve?

Issue Number: close #59718

Problem Summary:
BR snapshot restore reuses the last global ID when pre-allocates table IDs

What changed and how does it work?

pre-allocate from last global ID + 1

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-tests-checked do-not-merge/needs-triage-completed release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 24, 2025
Copy link

tiprow bot commented Feb 24, 2025

Hi @Leavrth. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

codecov bot commented Feb 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.5352%. Comparing base (907eddd) to head (8c15f02).
Report is 44 commits behind head on master.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #59719        +/-   ##
================================================
+ Coverage   72.9471%   74.5352%   +1.5881%     
================================================
  Files          1697       1713        +16     
  Lines        468911     470125      +1214     
================================================
+ Hits         342057     350409      +8352     
+ Misses       105773      97940      -7833     
- Partials      21081      21776       +695     
Flag Coverage Δ
integration 46.3162% <100.0000%> (?)
unit 72.2232% <100.0000%> (+0.0703%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.6910% <ø> (ø)
parser ∅ <ø> (∅)
br 61.4122% <100.0000%> (+16.3325%) ⬆️

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Feb 24, 2025
Copy link

ti-chi-bot bot commented Feb 24, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Tristan1900, YuJuncen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Feb 24, 2025
Copy link

ti-chi-bot bot commented Feb 24, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-02-24 12:06:45.408378327 +0000 UTC m=+271153.361536592: ☑️ agreed by YuJuncen.
  • 2025-02-24 17:24:45.856662305 +0000 UTC m=+290233.809820570: ☑️ agreed by Tristan1900.

@Tristan1900
Copy link
Contributor

Tristan1900 commented Feb 24, 2025

/hold

holding to wait for resolving CI errors

@ti-chi-bot ti-chi-bot bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 24, 2025
Signed-off-by: Jianjun Liao <[email protected]>
@Leavrth
Copy link
Contributor Author

Leavrth commented Feb 25, 2025

/unhold

@ti-chi-bot ti-chi-bot bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 25, 2025
@Leavrth
Copy link
Contributor Author

Leavrth commented Feb 25, 2025

/ok-to-test

@ti-chi-bot ti-chi-bot bot added the ok-to-test Indicates a PR is ready to be tested. label Feb 25, 2025
Signed-off-by: Jianjun Liao <[email protected]>
@ti-chi-bot ti-chi-bot bot merged commit c08679b into pingcap:master Feb 25, 2025
25 checks passed
@ti-chi-bot ti-chi-bot bot added the needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. label Feb 26, 2025
ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Feb 26, 2025
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #59780.
But this PR has conflicts, please resolve them!

ti-chi-bot bot pushed a commit that referenced this pull request Feb 27, 2025
@BornChanger BornChanger added needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. labels Mar 3, 2025
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.5: #59873.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Mar 3, 2025
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.1: #59874.
But this PR has conflicts, please resolve them!

ti-chi-bot bot pushed a commit that referenced this pull request Apr 17, 2025
zeminzhou pushed a commit to zeminzhou/tidb that referenced this pull request May 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BR snapshot restore reuses the last global ID when pre-allocates table IDs
5 participants