Skip to content

Conversation

winoros
Copy link
Member

@winoros winoros commented Feb 25, 2025

What problem does this PR solve?

Issue Number: close #59762

Problem Summary:

What changed and how does it work?

when we fixed the IdxCols for the path, we didn't update the full one for it.
So the full one may be smaller than the prefix one.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

fix the issue that the TiDB may panic when fixcontrol#44855 is enabled
修复当 fixcontrol#44855 开启时,TiDB 的会话可能执行崩溃的问题

@ti-chi-bot ti-chi-bot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/planner SIG: Planner size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 25, 2025
Copy link

codecov bot commented Feb 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.3633%. Comparing base (fed0251) to head (d698405).
Report is 765 commits behind head on master.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #59763        +/-   ##
================================================
+ Coverage   72.9574%   73.3633%   +0.4058%     
================================================
  Files          1697       1698         +1     
  Lines        468964     469345       +381     
================================================
+ Hits         342144     344327      +2183     
+ Misses       105748     103940      -1808     
- Partials      21072      21078         +6     
Flag Coverage Δ
integration 42.7776% <100.0000%> (?)
unit 72.4514% <100.0000%> (+0.0009%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling ∅ <ø> (∅)
parser ∅ <ø> (∅)
br 46.4784% <ø> (+0.0360%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Feb 26, 2025
Copy link

ti-chi-bot bot commented Feb 26, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AilinKid, hawkingrei

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Feb 26, 2025
Copy link

ti-chi-bot bot commented Feb 26, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-02-26 02:25:37.255942875 +0000 UTC m=+409085.209101142: ☑️ agreed by AilinKid.
  • 2025-02-26 02:31:21.753999243 +0000 UTC m=+409429.707157509: ☑️ agreed by hawkingrei.

@ti-chi-bot ti-chi-bot bot merged commit f66e8b1 into pingcap:master Feb 26, 2025
24 checks passed
@winoros winoros deleted the fixindexjoin branch April 7, 2025 12:10
@ti-chi-bot ti-chi-bot bot added the needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. label Apr 9, 2025
ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Apr 9, 2025
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.5: #60444.
But this PR has conflicts, please resolve them!

@ti-chi-bot ti-chi-bot bot added the needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. label Jul 9, 2025
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #62310.
But this PR has conflicts, please resolve them!

@ti-chi-bot ti-chi-bot bot added the needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. label Jul 9, 2025
ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Jul 9, 2025
@ti-chi-bot ti-chi-bot bot added needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. labels Jul 9, 2025
ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Jul 9, 2025
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.1: #62311.
But this PR has conflicts, please resolve them!

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Jul 9, 2025
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #62312.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Jul 9, 2025
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #62313.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/planner SIG: Planner size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

possible panic when trying index join with fixcontrol#44855 enabled
4 participants