-
Notifications
You must be signed in to change notification settings - Fork 6k
infoschema,metrics: use tidb_tikvclient_request_seconds_bucket to get the .999 cop req duration instead #59845
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
… the .999 cop req duration instead
Hi @XuHuaiyu. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #59845 +/- ##
================================================
+ Coverage 73.1389% 74.9161% +1.7772%
================================================
Files 1708 1754 +46
Lines 471809 479950 +8141
================================================
+ Hits 345076 359560 +14484
+ Misses 105518 97778 -7740
- Partials 21215 22612 +1397
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@XuHuaiyu: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lance6716, tangenta, zimulala The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
… the .999 cop req duration instead (pingcap#59845) ref pingcap#59815
In response to a cherrypick label: new pull request created to branch |
Signed-off-by: ti-chi-bot <[email protected]>
In response to a cherrypick label: new pull request created to branch |
In response to a cherrypick label: new pull request created to branch |
Signed-off-by: ti-chi-bot <[email protected]>
In response to a cherrypick label: new pull request created to branch |
In response to a cherrypick label: new pull request created to branch |
… the .999 cop req duration instead (pingcap#59845) ref pingcap#59815
What problem does this PR solve?
Issue Number: Ref #59815
Problem Summary:
The
TiDB -> Distsql -> Coprocessor Seconds 999
panel uses thetidb_tikvclient_cop_duration_seconds_bucket
metric to gather data, but this metric is redundant. We can usetidb_tikvclient_request_seconds_bucket
to obtain the same data. Therefore,tidb_tikvclient_cop_duration_seconds_bucket
can be removed to save storage space.client-go PR tikv/client-go#1602
What changed and how does it work?
Before:

After:

Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.