Skip to content

Conversation

XuHuaiyu
Copy link
Contributor

@XuHuaiyu XuHuaiyu commented Feb 28, 2025

What problem does this PR solve?

Issue Number: Ref #59815

Problem Summary:
The TiDB -> Distsql -> Coprocessor Seconds 999 panel uses the tidb_tikvclient_cop_duration_seconds_bucket metric to gather data, but this metric is redundant. We can use tidb_tikvclient_request_seconds_bucket to obtain the same data. Therefore, tidb_tikvclient_cop_duration_seconds_bucket can be removed to save storage space.

client-go PR tikv/client-go#1602

What changed and how does it work?

Before:
截屏2025-02-27 17 02 53

After:
截屏2025-02-27 17 02 39

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 28, 2025
Copy link

tiprow bot commented Feb 28, 2025

Hi @XuHuaiyu. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@XuHuaiyu XuHuaiyu mentioned this pull request Feb 27, 2025
6 tasks
Copy link

codecov bot commented Feb 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.9161%. Comparing base (57315c9) to head (925aa9e).
Report is 48 commits behind head on master.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #59845        +/-   ##
================================================
+ Coverage   73.1389%   74.9161%   +1.7772%     
================================================
  Files          1708       1754        +46     
  Lines        471809     479950      +8141     
================================================
+ Hits         345076     359560     +14484     
+ Misses       105518      97778      -7740     
- Partials      21215      22612      +1397     
Flag Coverage Δ
integration 48.8344% <ø> (?)
unit 72.3533% <ø> (+0.0085%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.6910% <ø> (ø)
parser ∅ <ø> (∅)
br 62.3042% <ø> (+15.0910%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@zimulala zimulala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Mar 3, 2025
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Mar 13, 2025
Copy link

ti-chi-bot bot commented Mar 13, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-03-03 03:34:29.413480874 +0000 UTC m=+239782.542400618: ☑️ agreed by zimulala.
  • 2025-03-13 14:38:05.086143687 +0000 UTC m=+453040.691672614: ☑️ agreed by lance6716.

Copy link

tiprow bot commented Mar 13, 2025

@XuHuaiyu: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
fast_test_tiprow 194c0d5 link true /test fast_test_tiprow

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@ti-chi-bot ti-chi-bot bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 20, 2025
Copy link

ti-chi-bot bot commented Mar 20, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lance6716, tangenta, zimulala

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Mar 20, 2025
@ti-chi-bot ti-chi-bot bot merged commit 12548a4 into pingcap:master Mar 24, 2025
24 checks passed
disksing pushed a commit to oh-my-tidb/tidb that referenced this pull request Mar 27, 2025
@XuHuaiyu XuHuaiyu added needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. labels Apr 3, 2025
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #60390.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #60391.
But this PR has conflicts, please resolve them!

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.1: #60392.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #60393.
But this PR has conflicts, please resolve them!

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.5: #60394.

@XuHuaiyu XuHuaiyu removed the needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. label Apr 3, 2025
zeminzhou pushed a commit to zeminzhou/tidb that referenced this pull request May 6, 2025
ti-chi-bot bot pushed a commit that referenced this pull request Jul 11, 2025
@you06 you06 mentioned this pull request Jul 11, 2025
13 tasks
ti-chi-bot bot pushed a commit that referenced this pull request Jul 12, 2025
ti-chi-bot bot pushed a commit that referenced this pull request Jul 21, 2025
@XuHuaiyu XuHuaiyu mentioned this pull request Jul 22, 2025
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants