planner: Limit fine grained shuffle usage for mpp join operators to ensure shuffle keys are the same with actual join keys (#59884) | plugin=pr/163

[ti-chi-bot]

This is an automated cherry-pick of #59884

What problem does this PR solve?

Issue Number: close #59877

Problem Summary:
Problem described here

What changed and how does it work?

This PR limit the fined grained shuffle usage to situations that shuffle keys are the same with actual join keys. In this way the pre-calculated hash codes will always be valid.

Check List

Tests

• Unit test
• Integration test
• Manual test (add detailed scripts or steps below)
• No need to test

  • I checked and no code files have been changed.

Side effects

• Performance regression: Consumes more CPU
• Performance regression: Consumes more Memory
• Breaking backward compatibility

Documentation

• Affects user behaviors
• Contains syntax changes
• Contains variable changes
• Contains experimental features
• Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

Fix the issue that the query result might be wrong when mpp hash join's equal condition keys have different data type.

[ti-chi-bot]

@yibin87 This PR has conflicts, I have hold it.
Please resolve them or ask others to resolve them, then comment /unhold to remove the hold label.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (release-8.5@83a5edc). Learn more about missing BASE report.

Additional details and impacted files

@@               Coverage Diff                @@
##             release-8.5     #59913   +/-   ##
================================================
  Coverage               ?   56.8871%           
================================================
  Files                  ?       1769           
  Lines                  ?     627674           
  Branches               ?          0           
================================================
  Hits                   ?     357066           
  Misses                 ?     246473           
  Partials               ?      24135           

Flag	Coverage Δ
integration	36.7971% <10.0000%> (?)
unit	72.5672% <100.0000%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
dumpling	52.8711% <0.0000%> (?)
parser	∅ <0.0000%> (?)
br	52.2585% <0.0000%> (?)

🚀 New features to boost your workflow:

• ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[yibin87]

/test build

[tiprow]

@yibin87: No presubmit jobs available for pingcap/[email protected]

In response to this:

/test build

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[purelind]

/test build

[tiprow]

@purelind: No presubmit jobs available for pingcap/[email protected]

In response to this:

/test build

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[yibin87]

/cc @windtalker @winoros @guo-shaoge

[yibin87]

/unhold

[windtalker]

lgtm

[ti-chi-bot]

[LGTM Timeline notifier]

Timeline:

• 2025-03-06 05:40:58.670076913 +0000 UTC m=+506571.798996657: ☑️ agreed by windtalker.
• 2025-03-06 05:51:45.402107634 +0000 UTC m=+507218.531027378: ☑️ agreed by guo-shaoge.

[ti-chi-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: guo-shaoge, windtalker, winoros

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [guo-shaoge,windtalker,winoros]
• pkg/planner/OWNERS [winoros]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment